Closed Bug 829184 Opened 7 years ago Closed 7 years ago

Refactor Data Choices preferences pane for bug 828829


(Firefox :: Preferences, defect)

Not set



Firefox 21
Tracking Status
firefox20 --- fixed


(Reporter: gps, Assigned: gps)




(1 file, 2 obsolete files)

We're changing some APIs around in bug 828829 that will require some modifications to the "data choices" preferences pane to make it work in the new world.
Current version of the patch. Holding off until the API is settled in bug 828829.

glandium: please approve the change. Before, we had a number of places in XUL code where we effectively did an "if MOZ_TELEMETRY_REPORTING | MOZ_SERVICES_HEALTHREPORT | MOZ_CRASHREPORTER". I felt this was sufficiently repeated and would be creating engineering debt and potential for incomplete updates when this set was modified. So, I created a new AC_DEFINE for it. Unification FTW. Please bikeshed about naming. Essentially we're trying to capture "does this build of application X have the ability to automatically submit any metrics data to Mozilla?"
Assignee: nobody → gps
Attachment #700584 - Flags: feedback?(mh+mozilla)
Blocks: 804745
Attached patch Refactor pref pane, v2 (obsolete) — Splinter Review
dolske gets /browser review. rnewman gets FHR specific behavior.
Attachment #700584 - Attachment is obsolete: true
Attachment #700584 - Flags: feedback?(mh+mozilla)
Attachment #701280 - Flags: review?(rnewman)
Attachment #701280 - Flags: review?(dolske)
Comment on attachment 701280 [details] [diff] [review]
Refactor pref pane, v2

Review of attachment 701280 [details] [diff] [review]:

r+ on these diffs.

Not sure where some of this code comes from (it's not in m-c, nor bug 828829), but at long as it got reviewed somewhere that's fine. The changes here are basic.
Attachment #701280 - Flags: review?(dolske) → review+
I changed the open_preferences() helper to wait on "Initialized" otherwise there is a race condition on "load" between init_all() in the preferences pane and the test runner. Locally things passed just fine! Hopefully it holds on all platforms on TBPL.
Attachment #701280 - Attachment is obsolete: true
Attachment #701280 - Flags: review?(rnewman)
Attachment #701334 - Flags: review?(dolske)
Attachment #701334 - Flags: review?(dolske) → review+
Comment on attachment 701334 [details] [diff] [review]
Refactor pref pane, v3

[Approval Request Comment]
See approval request in bug 804745.
Attachment #701334 - Flags: approval-mozilla-aurora?
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → Firefox 21
Comment on attachment 701334 [details] [diff] [review]
Refactor pref pane, v3
Attachment #701334 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.