Closed Bug 829377 Opened 7 years ago Closed 7 years ago

tap() in synthetic_gestures should also send mouse events & click event

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: mdas, Assigned: mdas)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch tap patch (obsolete) — Splinter Review
After Bug 823619, and according to https://groups.google.com/forum/#!topic/mozilla.dev.gaia/as_XclduM78

tap() should send:
  touchstart touchend mousemove mousedown mouseup click 

This patch adds that in.
Attachment #700775 - Flags: review?(jgriffin)
Attached patch tap patch (obsolete) — Splinter Review
Attachment #700775 - Attachment is obsolete: true
Attachment #700775 - Flags: review?(jgriffin)
Attachment #700776 - Flags: review?(jgriffin)
Comment on attachment 700776 [details] [diff] [review]
tap patch

Review of attachment 700776 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/touch/synthetic_gestures.js
@@ +508,4 @@
>        // Otherwise, schedule the next move event
>        if (last) {
>          mouseEvent('mouseup', lastX, lastY);
> +        if ((sendClick != undefined) && (sendClick != null)) {

can just use if (!sendClick)
Attachment #700776 - Flags: review?(jgriffin) → review+
(In reply to Jonathan Griffin (:jgriffin) from comment #2)
> Comment on attachment 700776 [details] [diff] [review]
> tap patch
> 
> Review of attachment 700776 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: testing/marionette/client/marionette/touch/synthetic_gestures.js
> @@ +508,4 @@
> >        // Otherwise, schedule the next move event
> >        if (last) {
> >          mouseEvent('mouseup', lastX, lastY);
> > +        if ((sendClick != undefined) && (sendClick != null)) {
> 
> can just use if (!sendClick)

whoops, I mean if (sendClick)
The whole patch queue wasn't exported to the patch. There's a small change to the patch, and I added the change you mentioned
Attachment #700776 - Attachment is obsolete: true
Attachment #700793 - Flags: review?(jgriffin)
Attachment #700793 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/3eae4564001c
Assignee: nobody → mdas
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.