829377 - tap() in synthetic_gestures should also send mouse events & click event

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: tap patch

After Bug 823619, and according to https://groups.google.com/forum/#!topic/mozilla.dev.gaia/as_XclduM78

tap() should send:
  touchstart touchend mousemove mousedown mouseup click 

This patch adds that in.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: tap patch

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 700776 [details] [diff] [review]
tap patch

Review of attachment 700776 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/touch/synthetic_gestures.js
@@ +508,4 @@
>        // Otherwise, schedule the next move event
>        if (last) {
>          mouseEvent('mouseup', lastX, lastY);
> +        if ((sendClick != undefined) && (sendClick != null)) {

can just use if (!sendClick)

Comment 3

[Jonathan Griffin (:jgriffin)]

(In reply to Jonathan Griffin (:jgriffin) from comment #2)
> Comment on attachment 700776 [details] [diff] [review]
> tap patch
> 
> Review of attachment 700776 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: testing/marionette/client/marionette/touch/synthetic_gestures.js
> @@ +508,4 @@
> >        // Otherwise, schedule the next move event
> >        if (last) {
> >          mouseEvent('mouseup', lastX, lastY);
> > +        if ((sendClick != undefined) && (sendClick != null)) {
> 
> can just use if (!sendClick)

whoops, I mean if (sendClick)

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: add another patch

The whole patch queue wasn't exported to the patch. There's a small change to the patch, and I added the change you mentioned

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

landed on m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3eae4564001c

uploaded to pypi as well.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3eae4564001c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3eae4564001c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3eae4564001c