829400 - Browser tabs close buttons are misplaced if the user touch the tab

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I would normally not complain and ask blocking-basecamp? for this kind of bug but it seems pretty bad to ship such an obvious bug in the browser when we are Mozilla and our specialty is normally Browsers! (soon it will be OS!)

Comment 1

[Jeni]

Attachment: Picture of issue

Comment 2

[amiller]

Attachment: Log cat

Comment 3

[Jeni]

Repro Steps:
1) Updated to Unagi Build ID: 20130411070205
2) Tap on Browser
3) Tap on > sign (Top right side)
4) Tap on + sign a couple times (Top right side)
5) Tap and hold on one of the tabs and slide to left or right 
6) Release quickly (Do not side all the way)
7) Repeat steps 5 a couple times
8) View what happens

Actual:
Tabs no longer aline with untouched tabs

Expected:
Tabs re-aline with untouched tabs when released 

Environmental  Variables:
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473
Gaia: e7e338a765e22334b40ced41489a785941382c66

Notes: 
Repro frequency: 100% 3/3
See attached picture and log cat for more info.
Workaround is to click back to browser.  Once you do this and go back to tabs they will be back in alinement.

Comment 4

[Ben Francis [:benfrancis]]

Stealing.

Comment 5

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/9819

Here's a fix which fixes the bug, moves presentation code out of the JavaScript file and into the CSS file and also fixes the regression of bug 830669 caused by bug 849389

Comment 6

[Dale Harvey (:daleharvey)]

Merged in: https://github.com/mozilla-b2g/gaia/commit/9374d2904a57a19b58ed67e0fc92ee80cb45659b

Comment 7

[Ben Francis [:benfrancis]]

Thanks Dale

Comment 8

[Ben Francis [:benfrancis]]

Comment on attachment 750500 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9819

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Displaced close button in browser
User impact if declined: Broken looking UI
Risk to taking this patch (and alternatives if risky): Low risk, mainly CSS changes
String or UUID changes made by this patch: none

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 9374d2904a57a19b58ed67e0fc92ee80cb45659b
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 10

[Ben Francis [:benfrancis]]

John, I can resolve this conflict and uplift as you asked by email, but I notice this patch is only tracking+, not leo+, are we still taking those? This is a low risk CSS patch I'd like to see in 1.1 but just want to make sure.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

It's in the queue because it is approval-gaia-v1+, not because of the tracking+

Comment 12

[Ben Francis [:benfrancis]]

Merged into v1-train in https://github.com/mozilla-b2g/gaia/commit/2a760f64de6ab72499a42cda8cd37118e5af72b3