829525 - nsMainThreadPtrHolder needs a virtual destructor

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

clang on mozilla-b2g18 is complaining about it:

In file included from /builds/slave/m-b2g18-osx64-g/build/dom/camera/CameraControlImpl.cpp:8:
In file included from /builds/slave/m-b2g18-osx64-g/build/dom/camera/CameraControlImpl.h:9:
../../dist/include/nsProxyRelease.h:157:1: error: delete called on 'nsMainThreadPtrHolder<nsICameraErrorCallback>' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
NS_IMPL_THREADSAFE_RELEASE(nsMainThreadPtrHolder<T>)
^
../../dist/include/nsISupportsImpl.h:1397:5: note: expanded from macro 'NS_IMPL_THREADSAFE_RELEASE'
    delete (this);                                                            \
    ^

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: nsMainThreadPtrHolder needs a virtual destructor

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d99397ff6bb8

Comment 3

[[e-mail]]

(In reply to Mike Habicher from comment #0)
> clang on mozilla-b2g18 is complaining about it:
> 
> In file included from
> /builds/slave/m-b2g18-osx64-g/build/dom/camera/CameraControlImpl.cpp:8:
> In file included from
> /builds/slave/m-b2g18-osx64-g/build/dom/camera/CameraControlImpl.h:9:
> ../../dist/include/nsProxyRelease.h:157:1: error: delete called on
> 'nsMainThreadPtrHolder<nsICameraErrorCallback>' that has virtual functions
> but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
Wasn't this fixed by bug 808146 (for the delete-non-vertual-dtor flag)?

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to [e-mail] from comment #3)
>
> Wasn't this fixed by bug 808146 (for the delete-non-vertual-dtor flag)?

The b2g18 tree seems to be missing that.  Thanks for the pointer--I'll land it.

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/abf0ab34d7c7 due to not being needed because of the fix in bug 808146.  Pushed that patch to b2g18 instead as https://hg.mozilla.org/releases/mozilla-b2g18/rev/ea47019235c0

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 700979 [details] [diff] [review]
nsMainThreadPtrHolder needs a virtual destructor

Patch not required, marking obselete.

Comment 7

[Bobby Holley (:bholley)]

Lest the adventure continue much more, take a look at the various other patches that were in the aforementioned queue for this code:

https://github.com/bholley/mozilla-central/commit/5d90cb0ec26c48215f32bc9bbbfc7a71e36efc22

https://github.com/bholley/mozilla-central/commit/d80a1fdf92d317834ed2158994f4bd23e524877b

https://github.com/bholley/mozilla-central/commit/208b16b7ee1e9efa0980ecce320f7fa460645f40

https://github.com/bholley/mozilla-central/commit/5b3f7699dc3886d0f84ac0f0531f2431e2872b72