82955 - XML unable to load chrome stylesheets without type="text/css" attribute

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Scott Collins]

Something changed recently that broke the loading of chrome stylesheets from
XML.  You can still load them from XUL but not from XML.  Go to the URL given
above and install my sidebar.  The bottom third is an XML file included in an
iframe.  It does not get the style it requests.  You can see that it is doing
the right thing by viewing its source from

  http://ScottCollins.net/panels/pb.xml

Comment 1

[Jason Johnston]

<?xml-stylesheet?> requires a type attribute.  Adding type="text/css" enables
the stylesheet call for me on Win32 build 2001052708.

Comment 2

[Scott Collins]

:-)

OK, in my defense ... hyatt looked at this, we viewed source, and he told me to
file the bug.  But adding type="text/css" makes it work.  Maybe then, this is
related to Peter van Der Beken's XML/HTML stylesheet loading changes (thanks jst
for this pointer), since it affects the XML part of the panel, but not the XUL
part.  Does that mean this is still a bug?  Maybe the bug is that the XUL parser
loads the stylesheet even when the type is absent.  That would make this be
hyatt's problem.  Sorry, Dave.  Over to you.

Comment 3

[John Morrison]

Actually, the |type| is not required, per the errata:
  http://www.w3.org/1999/06/REC-xml-stylesheet-19990629/errata

Comment 4

[Scott Collins]

re-assigning to peterv

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: Add !IsEmpty check

Comment 6

[Peter Van der Beken [:peterv]]

Looking for r and sr.

Comment 7

[Johnny Stenback (:jst)]

sr=jst

Comment 8

[Scott Collins]

r=scc

Comment 9

[ckritzer (gone)]

->jrgm

Comment 10

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 11

[Peter Van der Beken [:peterv]]

Checked in.

Comment 12

[John Morrison]

verified (http://jrgm/bugs/82955/foo.xml)