Closed Bug 829597 Opened 7 years ago Closed 7 years ago

Proxy connections completely broken by bug 769764

Categories

(Other Applications :: ChatZilla, defect, critical)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla-mozilla-20000923, Assigned: bugzilla-mozilla-20000923)

References

Details

(Whiteboard: [cz-0.9.90])

Attachments

(2 files, 1 obsolete file)

Bug 769764 removes all means of synchronously resolving URLs to proxy data, which naturally breaks ChatZilla's use of proxies (and only by lucky coding doesn't break all connections).
Blocks: 769764
This just fixes the display of DCC messages to show the remoteIP instead of localIP, making it match /dcc-list and the correct expectations, and the /dcc-list summary mislabelled failed as finished connections.
Assignee: rginda → silver
Status: NEW → ASSIGNED
Attachment #703980 - Flags: review?(samuel)
Attached patch Fix the connections to be async (obsolete) — Splinter Review
The real deal; change CBSConnection's connect method to be async in the face of proxies (and sync callback otherwise). Also includes some more DCC tidy-up of unused properties.
Attachment #703981 - Flags: review?(samuel)
This bug has quite crippled internal BBC operations comms with users stuck on Firefox 17, hence my vote.
Attachment #703980 - Flags: review?(samuel) → review+
Attachment #703981 - Flags: review?(samuel) → review+
This update fixes /cancel during the proxy lookup phase. If you /cancel during the proxy lookup phase, the cancelling message appears and then when it completes, the connection is cancelled.
Attachment #703981 - Attachment is obsolete: true
Attachment #705051 - Flags: review?(samuel)
Attachment #705051 - Flags: review?(samuel) → review+
http://hg.mozilla.org/chatzilla/file/4372bfb647e1
http://hg.mozilla.org/chatzilla/file/ff4fb7cb46c9

Simon Lucy, in about 45 minutes an automated build with these patches should appear on http://james-ross.co.uk/mozilla/chatzilla/nightly/ - please do let us know if this improves the situation at the BBC.

Likewise, anyone else using proxy connections, please report back if the nightly build fixes or doesn't fix the issue.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to James Ross from comment #5)
> http://hg.mozilla.org/chatzilla/file/4372bfb647e1
> http://hg.mozilla.org/chatzilla/file/ff4fb7cb46c9
> 
> Simon Lucy, in about 45 minutes an automated build with these patches should
> appear on http://james-ross.co.uk/mozilla/chatzilla/nightly/ - please do let
> us know if this improves the situation at the BBC.
> 
> Likewise, anyone else using proxy connections, please report back if the
> nightly build fixes or doesn't fix the issue.

That url 404s for me I'm afraid James.
(In reply to Simon Lucy from comment #6)
> (In reply to James Ross from comment #5)
> > http://hg.mozilla.org/chatzilla/file/4372bfb647e1
> > http://hg.mozilla.org/chatzilla/file/ff4fb7cb46c9
> > 
> > Simon Lucy, in about 45 minutes an automated build with these patches should
> > appear on http://james-ross.co.uk/mozilla/chatzilla/nightly/ - please do let
> > us know if this improves the situation at the BBC.
> > 
> > Likewise, anyone else using proxy connections, please report back if the
> > nightly build fixes or doesn't fix the issue.
> 
> That url 404s for me I'm afraid James.

Ignore that something peculiar in a different proxy, fine with Chrome
Whiteboard: [cz-0.9.90]
Thanks very much I thought I'd commented after testing but evidently not,
You need to log in before you can comment on or make changes to this bug.