829709 - Do not load CSS files from all skins by default

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Frédéric Buclin]

Bugzilla automatically loads CSS files from all existing skins installed. For instance, every time I visit a page on bmo, 5 global.css, 5 index.css, etc... files are fetched. This is totally useless and consumes time, even if loaded from the browser cache.

I vote to only load the skin selected in user prefs + Classic (Classic must always be loaded as skins generally do not have all the CSS rules, but only those which differ from Classic). This would limit files being loaded to 2 only, or 3 if there is something in skins/custom/.

Comment 1

[Frédéric Buclin]

Attachment: Firebug network analyze, index.cgi on bmo

See all the duplicated CSS files. I have no idea why there is some delay to load the remaining files. Any idea?

Comment 2

[Frédéric Buclin]

Loading all skins by default has been introduced by bug 322693 in Bugzilla 3.0. Per bug 322693 comment 5, wurblzap intentionally loads all skins by default so that you can select another skin from your browser, for single pages only. But nobody uses this feature, I'm pretty sure, and it's not persistent anyway, so that's a useless feature.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1.1

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 701337 [details] [diff] [review]
patch, v1.1

Review of attachment 701337 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl

Comment 5

[Frédéric Buclin]

dkl and glob want it for 4.4. I have no strong opinion on this -> 4.4.

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Template.pm
modified template/en/default/global/header.html.tmpl
Committed revision 8553.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/Template.pm
modified template/en/default/global/header.html.tmpl
Committed revision 8501.

Comment 7

[Frédéric Buclin]

Attachment: fix bustage

It was actually a bad idea to move [% PROCESS global/messages.html.tmpl %] later in header.html.tmpl. It must be called before the title is displayed. This patch fix bustage reported by QA tests.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/global/header.html.tmpl
Committed revision 8557.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified template/en/default/global/header.html.tmpl
Committed revision 8505.

Comment 8

[Frédéric Buclin]

Added to relnotes for 4.4rc2.