Do not load CSS files from all skins by default

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
User Interface
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

({perf})

Bugzilla 4.4
Bug Flags:
approval +
approval4.4 +

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
Bugzilla automatically loads CSS files from all existing skins installed. For instance, every time I visit a page on bmo, 5 global.css, 5 index.css, etc... files are fetched. This is totally useless and consumes time, even if loaded from the browser cache.

I vote to only load the skin selected in user prefs + Classic (Classic must always be loaded as skins generally do not have all the CSS rules, but only those which differ from Classic). This would limit files being loaded to 2 only, or 3 if there is something in skins/custom/.
(Assignee)

Comment 1

6 years ago
Created attachment 701235 [details]
Firebug network analyze, index.cgi on bmo

See all the duplicated CSS files. I have no idea why there is some delay to load the remaining files. Any idea?
(Assignee)

Comment 2

6 years ago
Loading all skins by default has been introduced by bug 322693 in Bugzilla 3.0. Per bug 322693 comment 5, wurblzap intentionally loads all skins by default so that you can select another skin from your browser, for single pages only. But nobody uses this feature, I'm pretty sure, and it's not persistent anyway, so that's a useless feature.
Depends on: 322693
(Assignee)

Comment 3

6 years ago
Created attachment 701337 [details] [diff] [review]
patch, v1.1
Assignee: ui → LpSolit
Status: NEW → ASSIGNED
Attachment #701337 - Flags: review?(dkl)
(Assignee)

Updated

6 years ago
Keywords: relnote
Target Milestone: --- → Bugzilla 5.0
(Assignee)

Updated

6 years ago
Keywords: perf
Comment on attachment 701337 [details] [diff] [review]
patch, v1.1

Review of attachment 701337 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl
Attachment #701337 - Flags: review?(dkl) → review+

Updated

6 years ago
Flags: approval?
Flags: approval4.4?
(Assignee)

Comment 5

6 years ago
dkl and glob want it for 4.4. I have no strong opinion on this -> 4.4.
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
Target Milestone: Bugzilla 5.0 → Bugzilla 4.4
(Assignee)

Comment 6

6 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Template.pm
modified template/en/default/global/header.html.tmpl
Committed revision 8553.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Template.pm
modified template/en/default/global/header.html.tmpl
Committed revision 8501.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

6 years ago
Created attachment 702360 [details] [diff] [review]
fix bustage

It was actually a bad idea to move [% PROCESS global/messages.html.tmpl %] later in header.html.tmpl. It must be called before the title is displayed. This patch fix bustage reported by QA tests.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/global/header.html.tmpl
Committed revision 8557.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified template/en/default/global/header.html.tmpl
Committed revision 8505.
(Assignee)

Comment 8

6 years ago
Added to relnotes for 4.4rc2.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.