Closed Bug 829758 Opened 7 years ago Closed 7 years ago

Use MatchOnly mode for str_search().

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: sstangl, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This doesn't affect any benchmark, but it's easy to do.
Attachment #701286 - Flags: review?(dvander)
Attachment #701286 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/f2e3d3913d70
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Depends on: 831658
Depends on: 832197
I have backed out this patch pending investigation into Bug 832197. This patch does not appear to be wrong, but some of the underlying cross-compartment references get hairy, but apparently only in the case of str_search(). Can be re-landed once that mess is sorted out.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2727e931b6c7
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Re-landed: Bug 832197 resolved in Bug 832217. Test cases included with this commit.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8619a2942136
https://hg.mozilla.org/mozilla-central/rev/8619a2942136
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.