Closed Bug 829787 Opened 7 years ago Closed 7 years ago

Fix broken jit-test failure reporting

Categories

(Core :: JavaScript Engine, defect, major)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: decoder, Unassigned)

References

Details

Attachments

(1 file)

Attached patch FixSplinter Review
In bug 827960, a bug got introduced that breaks jit-tests when they report failures with --show-failed-cmd:

    FAILURES:
    Process Process-2:
    Traceback (most recent call last):
      File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 232, in _bootstrap
        self.run()
      File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 88, in run
        self._target(*self._args, **self._kwargs)
      File "jit_test.py", line 432, in process_test_results_parallel
        ok = process_test_results(gen, num_tests, options, js)
      File "jit_test.py", line 527, in process_test_results
        return print_test_summary(failures, complete, doing, options)
      File "jit_test.py", line 466, in print_test_summary
        show_test(test)
      File "jit_test.py", line 459, in show_test
        print('    ' + subprocess.list2cmdline(get_test_cmd(test.path, test.jitflags, lib_dir, shell_args)))
    NameError: global name 'lib_dir' is not defined 


Easy fix is to propagate lib_dir and shell_args down to that function. In the long term this could use some serious refactoring.
Attachment #701315 - Flags: review?(jorendorff)
Comment on attachment 701315 [details] [diff] [review]
Fix

Review of attachment 701315 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this so quickly. Looks good.
Attachment #701315 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/5e82debfd1eb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.