82983 - Cannot open more than 1 bookmark properties dialog

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P1)

Description

[Chris Lyon]

Using build 2001052708 on Win2K.

Steps to reproduce:
1. Open the Manage Bookmarks Window.
2. Select a bookmark and hit Properties button (or right click, or Ctrl+I)
3. Keeping the first Properties dialog open, repeat step 2 with another (or the 
same) bookmark.

Results:
The first dialog disappears, and the new Properties dialog has empty fields and 
has the title Properties for "**bm_title**".

The following JS error appears twice:
Error: window.arguments has no properties
Source File: chrome://communicator/content/bookmarks/bm-props.js
Line: 52

Comment 1

[Gilles Durys]

Wouldn't that be the opposite of bug 59127 ?

Comment 2

[Blake Ross]

I see this, same build.

Comment 3

[timeless]

it shouldn't be, although it depends on how that bug is fixed.

Comment 4

[Chris Lyon]

On build 2001053120 on Win2K.  Slight change in the bahaviour of this bug:

A second dialog is never created, but the first one's fields become empty.

(no more Properties for "**bm_title**" titled dialogs)

Comment 5

[Oliver Klee]

Adding dataloss kw: Any changes made after opening the bm properties get lost
when all fields go empty.

Comment 6

[Jaime Rodriguez, Jr.]

Ben - Is this one you are gonna try and fix for TM0.9.4?

Comment 7

[Paul Chen]

Attachment: don't specify name for properties dialog and make it dependent

Comment 8

[Paul Chen]

chatted with Ben  on irc, fix is to not specify name and make dialog dependent
so that it doesn't clutter taskbar, cc-ing jag for r=

Comment 9

[Paul Chen]

Putting on the 0.9.4 list, marking nsbeta1+, p1, and mozilla0.9.4

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail]

Comment 11

[jag (Peter Annema)]

r=jag

Comment 12

[Paul Chen]

taking this one

Comment 13

[Paul Chen]

no, really, taking this bug from ben

sorry for the spam

Comment 14

[Asa Dotzler [:asa]]

a=asa on behalf of drivers.

Comment 15

[Paul Chen]

fix checked in

Comment 16

[Claudius Gayle]

VERIFIED Fixed 20010907 builds

Comment 17

[Chris Lyon]

It's back 2001120504 on Win2K (behaviour as described in comment #4).

Comment 18

[Blake Ross]

The bookmarksliner branch was from before this patch, so it regressed it.  I 
just checked in pchen's fix again.

Comment 19

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]