829866 - Play button overlay not removed from video when playing through javascript if video is display:none

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[an72]

Attachment: Stripped down HTML doc to reproduce problem

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20100101 Firefox/17.0 Iceweasel/17.0.1
Build ID: 20121228193015

Steps to reproduce:

Provide a custom video play button on a page. Use javascript to display video element, and begin playback.



Actual results:

Video appears and begins playback. Browser-provided play button overlay is not removed from the video element.

Happening in Firefox 18/Windows and Firefox 17/Linux.



Expected results:

Browser-provided play button overlay is removed from the video element.

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/c07595bee6cf
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120126 Firefox/12.0a1 ID:20120126171251
Bad:
http://hg.mozilla.org/mozilla-central/rev/206305cbbeb1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120127 Firefox/12.0a1 ID:20120127022250
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c07595bee6cf&tochange=206305cbbeb1

Suspected: 
	8d11d8bc8091	Jared Wein — Bug 666306 - Added a large play button when the video is not autoplay and with controls enabled. r=dolske

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Looking in to this it appears that this bug is happening because the video element is display:none right up until the "play()" function is called on the video.

The bindings are not attached to the video at this point, and so the code for the "play" event is not getting hit. To prove this, the browser debugger never hits the "play" event handling at http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/videocontrols.xml#508. After the video begins playing and has subsequently been paused, calling videoElement.play() from the Web Console does hit my breakpoint and removes the play button.

A simple band-aid approach would be hide this.clickToPlay in the "timeupdate" event handler if !this.video.paused.

Comment 3

[Justin Dolske [:Dolske]]

I'd say setupInitialState() should take of this -- it's already responsible for handling other stuff where the video might be doing things before we've attached.

Comment 4

[Raymond Heldt]

Attachment: Quick fix

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 702543 [details] [diff] [review]
Quick fix

Review of attachment 702543 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/widgets/videocontrols.xml
@@ +587,4 @@
>                                  this.setPlayButtonState(false);
>  
> +                                // Remove the play button overlay to give user an unobstructed view
> +                                this.clickToPlay.hidden = true;

See https://bugzilla.mozilla.org/show_bug.cgi?id=829866#c3, we should make this change in setupInitialState.

Comment 6

[Owen Coutts [:tallOwen]]

Attachment: Patch v0.1

I think the issue was happening after setupInitialState. In setupInitialState, all the controls are still hidden. This patch stops the original fade in from happening in the case that the video is already playing.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 702694 [details] [diff] [review]
Patch v0.1

Review of attachment 702694 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Do you need me to land this for you?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a820e3c2b03

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4a820e3c2b03