829870 - Appear the non-expected color gap on window that are opened from private one.

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screenshot (from Bug 827938)

+++ This bug was initially created as a clone of Bug #827938 +++

[Environment]
* Nightly 21, http://hg.mozilla.org/mozilla-central/rev/dccab70d8554
* OSX 10.8

[STR]
Open error console or popup window from the private browsing window.

[Result]
Please see screenshot (from Bug 827938).

This may be fixed if 827938 will fixed.

Comment 1

[(no longer active)]

Hmm, turns out that macBrowserOverlay.xul is used in console.xul, and that triggers a call to nonBrowserWindowDelayedStartup which calls gPrivateBrowsingUI.init() which triggers the drawintitlebar attribute to be set: <http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#6941>.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11b7a6a6bc4c

Comment 4

[(no longer active)]

Comment on attachment 701606 [details] [diff] [review]
Patch (v1)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 749394
User impact if declined: See comment 0
Testing completed (on m-c, etc.): Locally
Risk to taking this patch (and alternatives if risky): minimal risk.
String or UUID changes made by this patch: none.

Comment 5

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f59c93ee5d38

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/11b7a6a6bc4c

Comment 8

[Ada [:adalucinet]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0

Verified fixed on Firefox 20 beta 6 (Build ID: 20130320062118).

Comment 9

[Ada [:adalucinet]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0

Verified fixed on Firefox 21 beta 2 (Build ID: 20130408165307).