82993 - caret goes into generated content

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

1. Launch mozilla
2. view URL attached to this bug in browser
3. Edit page
4. Put selection caret in the middle of text "This is a paragraph"
5. Use keyboard's left arrow to move caret before that text

Caret goes into "<paragraph>" which is generated content. The cursor should not
enter that node.

It is also possible to directly put the caret into the generated content clicking
on it.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: Test case

Comment 2

[rubydoo123]

I also tried this on edit page, and was actually able to type text within the
generated content, however, on save the typed text did not get saved. I alos
noticed that selection was odd -- I get the dark blue when I select both part of
the generated content and part of the text string

Comment 3

[mjudge]

somehow the bit that says some frame is "generated" is not being set any more.. 
lemme check on this

Comment 4

[mjudge]

ok i made IsSelectable return false if the frame is generated. I also made the 
GENERATED_CONTENT flag inheirit from the parent frame.  Since that is the case, 
textframe no longer needs to do the hacky thing of looking at its parent to see 
if its in a generated area. It simply looks at itself.  This stops ALL selection 
of genearated content, appearance or otherwise.  Since Page->ViewSource no 
longer uses generated content, this is not a problem. ya!

I have allot of changes in my tree. If i left anything out of these difs or I 
left anything in that doesnt belong (shouldnt be the case) then please lemme 
know...

Comment 5

[mjudge]

Attachment: nsFrame. pass through generatedcontent bit. isSelectable now = false if generated

Comment 6

[mjudge]

Attachment: dont check parent for generated. just check yourself

Comment 7

[kinmoz]

r=[e-mail] lets get someone in layout, like attinasi, to sign off on 
this.

Comment 8

[Marc Attinasi]

Looks cool to me. AFAIK generated content cannot have non-generated content as a
child, so sr=attinasi

Comment 9

[kinmoz]

updating whiteboard

Comment 10

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 11

[mjudge]

its in

Comment 12

[sujay]

verified...

Comment 13

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: test case showing caret movement problem

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Thanks a lot for solving that, Mike !!!

There is still a little problem with the caret if the document contains
generated content:

1. open the document I attached above into Composer
2. put the caret into the second paragraph
3. use the left arrow to move caret from second to first paragraph

The caret stops on the generated content and does not jump to the first
paragraph...  You'll probably need to reopen.

Comment 15

[sujay]

REOPENING.

Comment 16

[sujay]

reopening based on Glazman's comments...

Comment 17

[kinmoz]

Also note that you can still put the caret in generated content by double 
clicking.

Comment 18

[rubydoo123]

must get fixed

reviewed and approved

Comment 19

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Similar issue : if the document contains an ISINDEX element, you can modify 
the generated textual content :

   1. launch composer
   2. add HTML tag     <isindex prompt="ISINDEX element ">
   3. switch to any of normal, alltags or preview mode
   4. put caret into "ISINDEX element"
   5. type in some text or remove some text

steps 4 and 5 should be impossible.

Comment 20

[mjudge]

ok i will have fix soon for double clicks. this is for the latest isindex 
problem daniel brought up. daniel what others have we missed?  Is this a good 
fix? how does this work in your tree with your modifications?

Comment 21

[mjudge]

Attachment: dif for override to stop selection of isindex elements

Comment 22

[mjudge]

ok double click fixes. where you could double click and drag or double click and 
caret disappeared and you could type in gen content...

Comment 23

[mjudge]

patches attached. the nsFrame one also has at the bottom some geometry fixes for 
other bug. just ignore that.

Comment 24

[mjudge]

Attachment: editor fix to not collapse selection until we are sure we have an element to collapse to.

Comment 25

[mjudge]

Attachment: double click and dragging shouldnt work if frame isnt selectable...

Comment 26

[Marc Attinasi]

[s]r=attinas for the nsFrame changes - minus the last part, which includes these
changes:
-        if (yDistance < closestYDistance)
-          closestXDistance = HUGE_DISTANCE;
+//        if (yDistance < closestYDistance)
+//          closestXDistance = HUGE_DISTANCE;

Comment 27

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Ok, your patches fix a lot of things and help for popup menus (bug detected by
beppe) but my issue from 2001-06-25 09:45 above is still here. Copying it here
for you :

1. open attachment 06 [details]/25/01 09:42 "test case showing caret movement problem"
   above into Composer
2. put the caret into the second paragraph
3. use the left arrow to move caret from second to first paragraph

The caret stops on the generated content and does not jump to the first
paragraph.

Comment 28

[mjudge]

should have marked this fixed..

Comment 29

[James Baxter]

Verified on 8-27 Build