Closed
Bug 830090
Opened 11 years ago
Closed 11 years ago
Access key for "Choose What I Share" button in info bar is broken
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Tracking
(firefox18 unaffected, firefox19 unaffected, firefox20 fixed, firefox21 verified)
VERIFIED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
firefox18 | --- | unaffected |
firefox19 | --- | unaffected |
firefox20 | --- | fixed |
firefox21 | --- | verified |
People
(Reporter: u60234, Assigned: mconnor)
References
Details
Attachments
(1 file)
838 bytes,
patch
|
gps
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130113 Firefox/21.0 The info bar for data reporting at the bottom of the window has a "Choose What I Share" button to preferences for this feature. This button should have C as access key as per the patch in bug 804745. But instead an (U) is appended to the label, which doesn't seem to work.
Updated•11 years ago
|
Component: General → Metrics and Firefox Health Report
Product: Firefox → Mozilla Services
Assignee | ||
Comment 3•11 years ago
|
||
accessKey, not accesskey.
Attachment #701994 -
Flags: review?(gps)
Comment 4•11 years ago
|
||
Comment on attachment 701994 [details] [diff] [review] use the right property name You've got to be kidding.
Attachment #701994 -
Flags: review?(gps) → review+
Comment 5•11 years ago
|
||
https://hg.mozilla.org/services/services-central/rev/e63a093f325e
Status: NEW → ASSIGNED
Whiteboard: [fixed in services]
Updated•11 years ago
|
Attachment #701994 -
Attachment is patch: true
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e63a093f325e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox18:
--- → unaffected
status-firefox19:
--- → unaffected
status-firefox20:
--- → affected
status-firefox21:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21
Comment 7•11 years ago
|
||
Comment on attachment 701994 [details] [diff] [review] use the right property name [Approval Request Comment] Blanket FHR request. Fix is a trivial one-liner.
Attachment #701994 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #701994 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•11 years ago
|
||
Pushed to Aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/dd0378c2d1b7
My understanding is that the infobar does not display until after the first 12 hours of Firefox use. Is there any way to speed up this timer?
Comment 10•11 years ago
|
||
Open about:config, set datareporting.policy.firstRunTime into the past, wait two minutes (or relaunch Firefox).
Comment 11•11 years ago
|
||
Thanks Richard. I can now confirm the access key is working in Aurora 21.0a2 2013-03-25.
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•11 years ago
|
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•