Closed Bug 830096 Opened 8 years ago Closed 8 years ago

Seamonkey-aurora and trunk needs to have release-l10n created

Categories

(SeaMonkey :: Release Engineering, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.18

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(2 files, 1 obsolete file)

Both SeaMonkey Aurora and SeaMonkey trunk needs to have release-l10n 
created in suite/config/(linux32,linux64,macosx-universal,macosx64,win32)
so that the next time around when they are merged, they won't
break.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attached patch Add release-l10n to aurora tree. (obsolete) — Splinter Review
Attachment #701676 - Flags: review?(bugspam.Callek)
Comment on attachment 701676 [details] [diff] [review]
Add release-l10n to aurora tree.

Review of attachment 701676 [details] [diff] [review]:
-----------------------------------------------------------------

r+a+ if you do as I describe :-) Please land the same resulting patch on central as well.

::: suite/config/mozconfigs/linux32/release-l10n
@@ +1,3 @@
> +if [ "$MOZ_UPDATE_CHANNEL" == "aurora" ]; then
> +  ac_add_options --with-l10n-base=../../releases/l10n/mozilla-aurora
> +fi;

don't add aurora here, this file is only used for releases, and we don't spin releases on aurora.

::: suite/config/mozconfigs/linux64/release-l10n
@@ +1,3 @@
> +if [ "$MOZ_UPDATE_CHANNEL" == "aurora" ]; then
> +  ac_add_options --with-l10n-base=../../releases/l10n/mozilla-aurora
> +fi;

nor here

::: suite/config/mozconfigs/macosx-universal/release-l10n
@@ +19,5 @@
> +fi
> +
> +if [ "$MOZ_UPDATE_CHANNEL" == "aurora" ]; then
> +  ac_add_options --with-l10n-base=../../releases/l10n/mozilla-aurora
> +fi;

here

::: suite/config/mozconfigs/macosx64/release-l10n
@@ +1,3 @@
> +if [ "$MOZ_UPDATE_CHANNEL" == "aurora" ]; then
> +  ac_add_options --with-l10n-base=../../releases/l10n/mozilla-aurora
> +fi;

here

::: suite/config/mozconfigs/win32/release-l10n
@@ +1,3 @@
> +if [ "$MOZ_UPDATE_CHANNEL" == "aurora" ]; then
> +  ac_add_options --with-l10n-base=../../releases/l10n/mozilla-aurora
> +fi;

and lastly here
Attachment #701676 - Flags: review?(bugspam.Callek)
Attachment #701676 - Flags: review+
Attachment #701676 - Flags: approval-comm-aurora+
[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

aurora release builds will break without this patch.
Attachment #701676 - Attachment is obsolete: true
Attachment #708025 - Flags: review+
Attachment #708025 - Flags: approval-comm-aurora?
Comment on attachment 708025 [details] [diff] [review]
Add release-l10n to aurora tree.(v2)

This patch was approved to aurora by Callek, but I couldn't forward + the approval.
Attachment #708054 - Flags: review+
Comment on attachment 708054 [details] [diff] [review]
Add release-l10n to trunk tree.

Forwarding a=comm-aurora/
Attachment #708054 - Flags: approval-comm-aurora+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.18
Attachment #708025 - Flags: approval-comm-aurora? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.