830109 - (SQLite3.7.15.2) Upgrade to SQLite 3.7.15.2

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

SQLite Release 3.7.15.2 On 2013-01-09 (3.7.15.2)

* Fix a bug, introduced in version 3.7.15, that causes an ORDER BY clause to be optimized out of a three-way join when the ORDER BY is actually required. Ticket 598f5f7596b055

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade to SQLite 3.7.15.2 - Mozilla changes

https://tbpl.mozilla.org/?tree=Try&rev=e0920965a277

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 701576 [details] [diff] [review]
Upgrade to SQLite 3.7.15.2 - Mozilla changes

Review of attachment 701576 [details] [diff] [review]:
-----------------------------------------------------------------

eww, this looks like may be hitting some of our queries, I think considered the size of the change would be really safer to uplift this version to aurora, please.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

I will request approval once this lands on m-c. Thanks for the quick review!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5b952215e6
https://hg.mozilla.org/integration/mozilla-inbound/rev/996cceda3ecd

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bd5b952215e6
https://hg.mozilla.org/mozilla-central/rev/996cceda3ecd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 701576 [details] [diff] [review]
Upgrade to SQLite 3.7.15.2 - Mozilla changes

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 824167
User impact if declined: Possible broken behavior
Testing completed (on m-c, etc.): On m-c
Risk to taking this patch (and alternatives if risky): revert Aurora to prior release
String or UUID changes made by this patch: none

Comment 7

[Marco Bonardo [:mak]]

to explain the possibilities that made us ask for this approval, basically some queries, when optimized by SQLite, may drop the ORDER BY clause, thus returning results in an unexpected sorting order. While our tests are passing, it's safer to take this small fix since we don't have 100% coverage.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 701576 [details] [diff] [review]
Upgrade to SQLite 3.7.15.2 - Mozilla changes

Very minor upgrade to SQLite. We're early in the Aurora cycle, so approving for uplift.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/50d9042de98f
https://hg.mozilla.org/releases/mozilla-aurora/rev/d4a5f2c9d76b