830125 - Avoid a potential recursive GetService call in the Preferences memory reporting code

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

See the patch which I'll attach in a moment.  This is necessary to avoid a recursive GetService assertion with the patch in bug 809949.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 701588 [details] [diff] [review]
Patch, v1

Review of attachment 701588 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.

It's annoying we have to do this kind of stuff, though.  It reminds me a lot of bug 810196, which was about similar cases where we can't do straightforward reporter registration due to a different constraint.  For those cases, I was thinking about attempting to register the memory reporter service earlier in the XPCOM start-up sequence.

::: modules/libpref/src/Preferences.cpp
@@ +252,5 @@
>  
>    gObserverTable = new nsRefPtrHashtable<ValueObserverHashKey, ValueObserver>();
>    gObserverTable->Init();
>  
> +  // Preferences;:GetInstanceForService() can be called from GetService(), and

Typo: ";:"

Comment 3

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/039837634ab9
https://hg.mozilla.org/integration/mozilla-inbound/rev/80adbcab0085

Comment 4

[Justin Lebar (not reading bugmail)]

> It's annoying we have to do this kind of stuff, though.

I agree.  Doing things on startup (and shutdown) in Gecko is hard.  :-/

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/039837634ab9
https://hg.mozilla.org/mozilla-central/rev/80adbcab0085

Comment 6

[Justin Lebar (not reading bugmail)]

Comment on attachment 701588 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Simple patch, needed for bug 809949.

Comment 7

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/f482244c5966