830190 - Switch download manager from ids to guids

Status: RESOLVED DUPLICATE of bug 833015

(SeaMonkey :: Download & File Handling, defect)

Description

[[e-mail]]

Toolkit has deprecated the use of ids to identify downloads.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philip Chee]

Comment on attachment 701649 [details] [diff] [review]
Proposed patch

Looks good.
>          for each (let dldata in selItemData)
> -          pauseDownload(dldata.dlid);
> +          dldata.dld.pause();
["for each" isn't going away any time soon but since it's a E4Xism perhaps we should take the opportunity to switch our code to use for...in in a follow up bug]

Comment 3

[[e-mail]]

(In reply to Philip Chee from comment #2)
> (From update of attachment 701649 [details] [diff] [review])
> >          for each (let dldata in selItemData)
> > -          pauseDownload(dldata.dlid);
> > +          dldata.dld.pause();
> ["for each" isn't going away any time soon but since it's a E4Xism perhaps
> we should take the opportunity to switch our code to use for...in in a
> follow up bug]
[I assume you meant for...of]

Comment 4

[Philip Chee]

> [I assume you meant for...of]
[you assume correctly ;)]

Comment 5

[Ian Neal]

Comment on attachment 701649 [details] [diff] [review]
Proposed patch

Something is broken with this patch applied.
STR
1/ Open Download manager
2/ Go to http://www.seamonkey-project.org/start/
3/ Right click on SeaMonkey graphic and select Save Image As
4/ Select location and save
5/ Look in download manager

Expect Result
1/ Single line with Finished in it

Actual Result
1/ Four line:
* 1 with completed progress bar 8.7 of 8.7 KB
* 1 with empty progress bar 0 bytes of 8.7 KB
* 1 with 0 in progress column, 0 bytes in transferred column and Not Started in Speed column
* 1 with Finished in Progress, 8.7 of 8.7 KB

In error console there is multiple messages all saying one of the following:
Timestamp: 26/01/13 14:56:02
Error: TypeError: dld is undefined
Source File: chrome://communicator/content/downloads/treeView.js
Line: 141
Timestamp: 26/01/13 14:56:02
Warning: ReferenceError: reference to undefined property dl.dld
Source File: chrome://communicator/content/downloads/treeView.js
Line: 154
Timestamp: 26/01/13 14:56:02
Error: TypeError: dl.dld is undefined
Source File: chrome://communicator/content/downloads/treeView.js
Line: 154

Comment 6

[[e-mail]]

(In reply to Ian Neal from comment #5)
> Something is broken with this patch applied.
Yes, there were a couple of bugs in addDownload, I have fixed them in the rollup patch in bug 833015. I might as well close this bug, all the work is being handled there now.