830288 - update notification count when the download/update is trigerred by the app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

In Bug 826946, we fixed how download can be triggered by the app itself, and we had to change a lot how updates work in System.

A small bug was not fixed: the notification count is not updated when the download is triggered by the app.

This should be quite simple to fix.

To test this, one can use the app at https://github.com/julienw/self-updating-packaged-app.

Comment 1

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 703979 [details]
patch

comments added in the PR.

re-ask for review when it's fixed :)

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 703979 [details]
patch

r=me

thanks


asking for approval from vivien :

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: inconsistent behaviour for stubs
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Julien Wajsberg [:julienw]]

I'd really like this to go in shira because this leads to inconsistent behaviour when updating the stub apps -- that we _will_ be shipping.

Comment 5

[Julien Wajsberg [:julienw]]

https://github.com/mozilla-b2g/gaia/commit/71040d5684d4898487758bed1c9b28045c8e5336

Comment 6

[Jason Smith [:jsmith]]

Why remove the approval? At it's current state, this will not land on v1.01 branch. I think we should try that get that in.

Okay, and another point of confusion - if this gets approval for v1.01, wouldn't that imply that shira get it as well?

Comment 7

[Jason Smith [:jsmith]]

I also don't think this is going to block for the same reasons why we didn't block on it for tef. I don't expect that to change. I'm reverting the flags.

Comment 8

[Julien Wajsberg [:julienw]]

This is nonsense. If you think it should go to shira (and thus ask for approval) why don't you just set it to shira+ ?

So much time lost on useless processes.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Julien Wajsberg [:julienw] from comment #8)
> This is nonsense. If you think it should go to shira (and thus ask for
> approval) why don't you just set it to shira+ ?
> 
> So much time lost on useless processes.

shira+ should really be only used when we think it's stop ship. approval exists for the purpose of making sure risk vs. reward warrants taking the patch in.

I would think of this as a more of a quality control process.

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 703979 [details]
patch

Has test so seems safe enough for the v1 train (v1.0.1 release)

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 27fc1aa6fddb07daf64710a1113153069052b195

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1