830295 - Custom linker segfault handler keeps references to library handles

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Mike Hommey [:glandium]]

The segfault handler used for on-demand decompression gets a handle for the library, with the intent of not touching the refcounter but ends up increasing it, and never decreasing it. So in the end, libxul.so has > 1500 "references".

Comment 1

[Mike Hommey [:glandium]]

Attachment: Avoid RefPtr<LibHandle> triggering recursive calls to ~CustomElf, and use it in the linker segfault handler

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/136b90350752

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/136b90350752