830303 - Fix plugin-container spawning on BSD after bug 753046

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Landry Breuil (:gaston)]

Bug 753046 had a wrong chunk : in https://hg.mozilla.org/mozilla-central/rev/b6f7fe8e2363

    1.31 -# ifdef OS_LINUX
    1.32 -#  ifdef MOZ_WIDGET_ANDROID
    1.33 +# if defined(OS_LINUX) || defined(OS_BSD)
    1.34 +#  if defined(MOZ_WIDGET_ANDROID) || defined(OS_BSD)
    1.35          path += "/lib";
    1.36  #  endif  // MOZ_WIDGET_ANDROID

With that change, the code adds /lib to the native GRE path - while it shouldnt, the libs are installed in the same dir as ffx/etc. Consequence : spawning plugin-container is broken, since the LD_LIBRARY_PATH doesnt contain the correct path to libxul/libxpcom.

This was probably an oversight.

Comment 1

[Landry Breuil (:gaston)]

Attachment: Remove bogus OS_BSD

Comment 2

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80b36fe6cf0c

Comment 3

[Landry Breuil (:gaston)]

Comment on attachment 701752 [details] [diff] [review]
Remove bogus OS_BSD

[Approval Request Comment]
Regression caused by (bug #): 753046
User impact if declined: external plugin fail to load on *BSD
Testing completed (on m-c, etc.): tested here, patch against 19.0b1 & 18.0 confirmed to fix the issue
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 701752 [details] [diff] [review]
Remove bogus OS_BSD

Approving for Aurora/Beta since this is NPOTB. Will have an answer for you on release tomorrow around noon PT. Would be great if you were available to uplift at that time.

Comment 5

[Landry Breuil (:gaston)]

http://hg.mozilla.org/releases/mozilla-beta/rev/02eb5acd9c6b
http://hg.mozilla.org/releases/mozilla-aurora/rev/2b7a1f678d49

awaiting for my -release clone to finish to push there...

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/80b36fe6cf0c

Comment 7

[Landry Breuil (:gaston)]

I'm sorry i wont be able to push to -release branch right now (disk full, cant checkout a clone..) - can anyone push it on my behalf ?

Comment 8

[Landry Breuil (:gaston)]

https://hg.mozilla.org/releases/mozilla-release/rev/f9bab2e48160

Finally.

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

I have tried for several hours to install FF 19beta2 on OpenBSD 5.2 without success. I only managed to install FF 13, which was found on the OpenBSD repositories.

Landry, could you please verify this?

Comment 10

[Landry Breuil (:gaston)]

As i said in comment 3, it works for me now. 

You'd have to run OpenBSD-current to test FF19.0b1 or FF18, and i'd have to send you a package with the fix :)
Or with -current you can grab http://ftp.openbsd.org/pub/OpenBSD/snapshots/packages/i386/firefox-18.0p0.tgz and install it with pkg_add - only i386 atm, the amd64 package didnt reach the ftp yet.

Or if you really want to build/verify it yourself, i can send you all the instructions to build the port from my git repo at http://rhaalovely.net/cgit/mozilla-firefox/ ....

Comment 11

[u279076]

Hi Landry,

Can you please confirm that this is now fixed for you with the following builds?
* Firefox 18.0.1
* Firefox 19.0b2
* Firefox 20.0a2 (latest)
* Firefox 21.0a1 (latest)

Thanks

Comment 12

[Landry Breuil (:gaston)]

Well, seems it wont be fixed in pristine 18.0.1 since for some reason my push wasnt in time for the candidate build1 (http://hg.mozilla.org/releases/mozilla-release/log/eecd28b7ba09/ipc/glue/GeckoChildProcessHost.cpp doesnt have it, and it's what's in 18.0.1..)

As for the others, it should be okay, i just have to build & test them, but m-c is busted for me atm because of bug 784841.

Consider it fixed anyway, as i'm shipping builds to my users with the patch backported...

Comment 13

[u279076]

Hmm...okay, please keep us updated Landry.

Comment 14

[Alex Keybl [:akeybl]]

(In reply to Landry Breuil (:gaston) from comment #12)
> Well, seems it wont be fixed in pristine 18.0.1 since for some reason my
> push wasnt in time for the candidate build1
> (http://hg.mozilla.org/releases/mozilla-release/log/eecd28b7ba09/ipc/glue/
> GeckoChildProcessHost.cpp doesnt have it, and it's what's in 18.0.1..)
> 
> As for the others, it should be okay, i just have to build & test them, but
> m-c is busted for me atm because of bug 784841.
> 
> Consider it fixed anyway, as i'm shipping builds to my users with the patch
> backported...

Looks like we didn't comment here, but yeah - this didn't make our release sadly, as it landed after our go and wasn't a hard blocker for release. It is on mozilla-release however, for others pulling the repo.

Comment 15

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old