830380 - [FTU UX VD] Tutorial. Replace the third image

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: The image to replace the existing

Replace the third step image for the one attached.

Comment 1

[Fernando Campo (:fcampo)]

https://github.com/gordonbrander/gaia/pull/99

Comment 2

[Sam Joch [:samjoch]]

Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/f06b416db6e99739af33e0524028c023bc25a3de

Comment 3

[Patryk Adamczyk [:patryk] UX]

The position of the delete "x" should be updated to upper left like on the device.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think patryk is right... the x isn't in the right spot...

Comment 5

[Patryk Adamczyk [:patryk] UX]

Attachment: Homescreen X

Can you please match the alignment of the FRE to that of the homescreen.

Comment 6

[Patryk Adamczyk [:patryk] UX]

Vicky, can you attach the updated graphics and send it to sam for integration. Thanks!

Comment 7

[Victoria Gerchinhoren [:vicky]]

Attachment: Image number 3 of the current tutorial.

Comment 8

[Victoria Gerchinhoren [:vicky]]

Attached the asset to replace the current 3rd image with updated delete "x" positioning.

Comment 9

[Fernando Campo (:fcampo)]

The new change of image is on PR https://github.com/gordonbrander/gaia/pull/130

Comment 10

[Maria Angeles Oteo (:oteo)]

Hi Fernando or Sam, after the Pull Request corresponding revision can you land the patch in master? 

As there is no clear answers about the UX branch purpose right now, it'd be better to land it in master so after that, we can ask for uplifting the patch to v1-train. Otherwise I am afraid the work done will be lost and it will not land in time or never in the commercial release v1.1.

Comment 11

[Sam Joch [:samjoch]]

Revert last commit in ux branch.
Landed new commit in uxbranch: https://github.com/gordonbrander/gaia/commit/ed7ce996aef66a243776aefcb57b6148679dae2d

Comment 12

[Sam Joch [:samjoch]]

https://github.com/mozilla-b2g/gaia/commit/25d9e53380db967d76223c5f1e1940ed907ed447

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified on Master

Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"

Comment 14

[Stephany Wilkes]

Fernando or Sam: Is this ready to raise to approval? with user value and risk in the comments?

Comment 15

[Fernando Campo (:fcampo)]

Attachment: Link to commit https://github.com/mozilla-b2g/gaia/commit/c82863e

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: The user will see differences on icons between images on tutorial
Testing completed: 
Risk to taking this patch (and alternatives if risky): Low risk, only asset changes
String or UUID changes made by this patch:

Comment 16

[Stephany Wilkes]

Thanks Fernando - appreciate it!

Comment 17

[Sam Joch [:samjoch]]

Master commit is c82863e

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit c82863e22735fcd609aa98dc091a8f1eabbf18f0 as:
v1-train: ab090dbd6f68ccf4c88513e6a476787697bdcb59