830388 - Avoid multiple bind calls in debugger-controller.js when handling object expansions

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

this._fetchScopeVariables.bind(this, aScope, aEnv); and
this._fetchVarProperties.bind(this, aVar, aGrip);

These little things can be easily avoided, and they're potentially called thousands (milliards! millions!) of times for each variable and property. That's not so memory friendly.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 707002 [details] [diff] [review]
v1

Looks good. r+ as long as all tests pass.

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/1a0e1c835525

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/1a0e1c835525