Closed
Bug 830396
Opened 12 years ago
Closed 12 years ago
add back nsIDOMCSSValueList
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
Tracking | Status | |
---|---|---|
firefox19 | --- | unaffected |
firefox20 | + | fixed |
firefox21 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
(Keywords: addon-compat)
Attachments
(1 file, 2 obsolete files)
9.28 KB,
patch
|
bzbarsky
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #701855 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•12 years ago
|
||
Comment on attachment 701855 [details] [diff] [review] patch Can you add a test to dom/tests/mochitest/chrome/file_DOM_element_instanceof.xul ? I would expect that to fail without the classinfo bits I mentioned on irc...
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #701962 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #701855 -
Attachment is obsolete: true
Attachment #701855 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #2) > Comment on attachment 701855 [details] [diff] [review] > patch > > Can you add a test to > dom/tests/mochitest/chrome/file_DOM_element_instanceof.xul ? that seems to be tricky because it appears the iframe doesn't get a pres shell, so its hard to get something that should be a CSSValueList...
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #702149 -
Flags: review?(bzbarsky)
![]() |
||
Comment 6•12 years ago
|
||
Comment on attachment 702149 [details] [diff] [review] bug 830396 - add back nsIDOMCSSValueList >+ ok(cs.getPropertyCSSValue("cursor") instanceof nsIDOMCSSValueList, >+ "cSSValueList should be a nsIDOMCSSValueList"); Please fix the indent and capitalize that first 'C'. r=me
Attachment #702149 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 7•12 years ago
|
||
Note that we'll want this on Aurora 20 too.
What's the motivation for this?
![]() |
||
Comment 9•12 years ago
|
||
Addons use it. See comments in the bug this blocks.
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c525391efd0d
![]() |
||
Comment 11•12 years ago
|
||
Comment on attachment 702149 [details] [diff] [review] bug 830396 - add back nsIDOMCSSValueList [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 798567 User impact if declined: Breaks some extensions Testing completed (on m-c, etc.): Passes tests Risk to taking this patch (and alternatives if risky): Just let the extensions involved deal. Some already have. String or UUID changes made by this patch: Effectively changes the UUID of nsIDOMCSSValueList compared to Firefox 19, but compared to the current state of 20 just adds the interface.
Attachment #702149 -
Flags: approval-mozilla-aurora?
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c525391efd0d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Updated•12 years ago
|
status-firefox19:
--- → unaffected
status-firefox20:
--- → affected
tracking-firefox20:
--- → +
Keywords: addon-compat
Comment 13•12 years ago
|
||
Comment on attachment 702149 [details] [diff] [review] bug 830396 - add back nsIDOMCSSValueList Approving for uplift given add-on compat. We're not concerned about the UUID change, given the fact that FF20 is still on Aurora.
Attachment #702149 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 14•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5cc57edb1323
status-firefox21:
--- → fixed
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•