830396 - add back nsIDOMCSSValueList

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 701855 [details] [diff] [review]
patch

Can you add a test to dom/tests/mochitest/chrome/file_DOM_element_instanceof.xul ?

I would expect that to fail without the classinfo bits I mentioned on irc...

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: bug 830396 - add back nsIDOMCSSValueList

Comment 4

[Trevor Saunders (:tbsaunde)]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 701855 [details] [diff] [review]
> patch
> 
> Can you add a test to
> dom/tests/mochitest/chrome/file_DOM_element_instanceof.xul ?

that seems to be tricky because it appears the iframe doesn't get a pres shell, so its hard to get something that should be a CSSValueList...

Comment 5

[Trevor Saunders (:tbsaunde)]

Attachment: bug 830396 - add back nsIDOMCSSValueList

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 702149 [details] [diff] [review]
bug 830396 - add back nsIDOMCSSValueList

>+  ok(cs.getPropertyCSSValue("cursor") instanceof nsIDOMCSSValueList,
>+  "cSSValueList should be a nsIDOMCSSValueList");

Please fix the indent and capitalize that first 'C'.

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Note that we'll want this on Aurora 20 too.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

What's the motivation for this?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Addons use it.  See comments in the bug this blocks.

Comment 10

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c525391efd0d

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 702149 [details] [diff] [review]
bug 830396 - add back nsIDOMCSSValueList

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 798567 
User impact if declined: Breaks some extensions
Testing completed (on m-c, etc.): Passes tests
Risk to taking this patch (and alternatives if risky): Just let the extensions
   involved deal.  Some already have.
String or UUID changes made by this patch: Effectively changes the UUID of
   nsIDOMCSSValueList compared to Firefox 19, but compared to the current state
   of 20 just adds the interface.

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c525391efd0d

Comment 13

[Alex Keybl [:akeybl]]

Comment on attachment 702149 [details] [diff] [review]
bug 830396 - add back nsIDOMCSSValueList

Approving for uplift given add-on compat. We're not concerned about the UUID change, given the fact that FF20 is still on Aurora.

Comment 14

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5cc57edb1323