Closed Bug 830413 Opened 7 years ago Closed 7 years ago

Port |Bug 827303 - Firefox core and crypto services components assume services/sync is built|

Categories

(SeaMonkey :: Sync UI, defect, blocker)

defect
Not set
blocker

Tracking

(seamonkey2.17 fixed)

RESOLVED FIXED
seamonkey2.18
Tracking Status
seamonkey2.17 --- fixed

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

Attachments

(1 file)

The package-manifest.in changes made in bug 827303 need to be ported in order to have Sync fully functional again. The base bug already landed on Aurora, too.

I haven't tested the patch yet, but other than putting the entries where they belong in the alphabet it's a straight port.

Hartmut, you reportedly saw an issue with reopening closed tabs with builds you created from current trunk code. This is probably due to this bug. Please check whether the attached patch fixes it for you.
Attachment #701869 - Flags: review?(neil)
Attachment #701869 - Flags: approval-comm-aurora?
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #0)

> Hartmut, you reportedly saw an issue with reopening closed tabs with builds
> you created from current trunk code. This is probably due to this bug.
> Please check whether the attached patch fixes it for you.

Yes, my new build contains your patch and the issue is gone.
Comment on attachment 701869 [details] [diff] [review]
patch [Checkin: Comments 3 and 5]

I see both of these in my objdir, that's good enough for me.
Attachment #701869 - Flags: review?(neil) → review+
Comment on attachment 701869 [details] [diff] [review]
patch [Checkin: Comments 3 and 5]

http://hg.mozilla.org/comm-central/rev/bc0de6d8ef78
Attachment #701869 - Attachment description: patch → patch [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.18
Comment on attachment 701869 [details] [diff] [review]
patch [Checkin: Comments 3 and 5]

a=me for comm-aurora
Attachment #701869 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 701869 [details] [diff] [review]
patch [Checkin: Comments 3 and 5]

http://hg.mozilla.org/releases/comm-aurora/rev/1f3b4fd70db8
Attachment #701869 - Attachment description: patch [Checkin: Comment 3] → patch [Checkin: Comments 3 and 5]
You need to log in before you can comment on or make changes to this bug.