Closed Bug 830418 Opened 11 years ago Closed 11 years ago

hide health report menu items if health report is disabled

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 21
Tracking Status
firefox18 --- unaffected
firefox19 --- unaffected
firefox20 --- fixed
firefox21 --- fixed

People

(Reporter: mconnor, Assigned: mconnor)

References

Details

(Whiteboard: [fhr])

Attachments

(1 file)

Attached patch add some #ifdefsSplinter Review
*headdesk*
Attachment #701872 - Flags: review?(rnewman)
Comment on attachment 701872 [details] [diff] [review]
add some #ifdefs

Review of attachment 701872 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/utilityOverlay.js
@@ +533,3 @@
>  /**
>   * Opens the troubleshooting information (about:support) page for this version
>   * of the application.

This comment is copypasta from the previous function. Fix it while you're here!
Attachment #701872 - Flags: review?(rnewman) → review+
Comment on attachment 701872 [details] [diff] [review]
add some #ifdefs

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 719
User impact if declined: non-working menuitems while FHR is disabled.
Testing completed (on m-c, etc.): tested locally, straightforward #ifdef out of non-working UI
Risk to taking this patch (and alternatives if risky): almost zero
String or UUID changes made by this patch: none
Attachment #701872 - Flags: approval-mozilla-aurora?
Comment on attachment 701872 [details] [diff] [review]
add some #ifdefs

Approving on aurora , just adding a couple of if-defs, low risk
Attachment #701872 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/services/services-central/rev/51f8cc9091ba
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Whiteboard: [fhr][fixed in services]
https://hg.mozilla.org/mozilla-central/rev/51f8cc9091ba
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fhr][fixed in services] → [fhr]
Target Milestone: --- → Firefox 21
You need to log in before you can comment on or make changes to this bug.