830429 - Reduce the threshold for slow main thread SQL to 50ms

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Comment 1

[Vladan Djeric (:vladan)]

There are two caveats with this:

1) The Telemetry ping size will increase since we'll likely be reporting a lot of new SQL strings
2) We've got our hands full fixing the top sources of slow SQL already. On the other hand, this might uncover some easy wins

Comment 2

[Marco Bonardo [:mak]]

I also think 10ms is too low for now, it's going to report most queries.
The current threshold is 100ms, I think we could reduce it to 50 as a first step.

Comment 3

[(no longer active)]

OK, let's do 50ms then.  The reason I'm interested in this is to see how many easy wins we can have.

Comment 4

[Vladan Djeric (:vladan)]

Attachment: Different threshols for main and helper threads

Trivial patch. Nominating Nathan for review, since Taras is on holiday for MLK day

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 704668 [details] [diff] [review]
Different threshols for main and helper threads

Yeah, OK.

Comment 6

[Vladan Djeric (:vladan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/584060b0efaf

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/584060b0efaf