830489 - Delay database initialization and/or opening

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Gregory Szorc [:gps]]

Per discussions with Perf team, we should consider delaying the following:

1) Initial database creation on first run
2) Opening the database on every application run

Comment 1

[Gregory Szorc [:gps]]

Attachment: Delay DB init on first run, v1

We will now delay FHR loading the first time the profile is used by 60s instead of the default 10s.

This only addresses half of the bug but half is better than none. We can file a follow-up to deal with remaining issues.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 710436 [details] [diff] [review]
Delay DB init on first run, v1

Review of attachment 710436 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/datareporting/DataReportingService.js
@@ +148,1 @@
>                              DEFAULT_LOAD_DELAY_MSEC;

Fix indent.

@@ +148,4 @@
>                              DEFAULT_LOAD_DELAY_MSEC;
> +        } else {
> +          delayInterval = this._prefs.get("service.loadDelayFirstRunMsec") ||
> +                            DEFAULT_LOAD_DELAY_FIRST_RUN_MSEC;

Fix indent.

@@ +252,5 @@
>                                                   this.policy,
>                                                   this.sessionRecorder);
> +
> +    // Record first run so subsequent service loads aren't as delayed.
> +    this._prefs.set("service.firstRun", true);

Observation: HealthReporter inits in the background, so it's quite possible that they quit before initialization has finished. That is, if I quit after 61 seconds, firstRun = true, but the DB has not finished initializing, and it'll happen after ten seconds next time.

IMO this isn't a big enough issue to warrant setting firstRun within HealthReporter, but it's worth calling out explicitly (if only in a bug comment!).

Comment 3

[Gregory Szorc [:gps]]

Attachment: Delay DB init on first run, v2

We have an onInit promise. We should use it.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/services/services-central/rev/42abb7556fd9

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/42abb7556fd9