Closed
Bug 830553
Opened 12 years ago
Closed 12 years ago
Make every single assert in nsWrapperCache.h fatal
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: mccr8, Assigned: bzbarsky)
Details
Attachments
(1 file)
2.58 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
There are a few of these NS_ASSERTIONs in nsWrapperCache, and they all look pretty awful. bz had a problem that took us a long time to pin down because it wasn't clear where the problem was. We should make these into MOZ_ASSERT to catch problems earlier. And possibly consider making them crash in release builds...
Assignee | ||
Comment 1•12 years ago
|
||
I think we should strongly consider making every single assert in nsWrapperCache.h fatal.
Reporter | ||
Updated•12 years ago
|
Summary: Make !PreservingWrapper() into fatal assertions in nsWrapperCache → Make every single assert in nsWrapperCache.h fatal
Assignee | ||
Comment 2•12 years ago
|
||
Andrew, are you taking this, or should I? I have most of this patch already.... Would need to run it through try, I guess.
Reporter | ||
Comment 3•12 years ago
|
||
I haven't started on it. Feel free to do it if you want, or I can probably get to it in a day or two.
Assignee | ||
Comment 4•12 years ago
|
||
Try run at https://tbpl.mozilla.org/?tree=Try&rev=17680b7ab2c0
Attachment #702135 -
Flags: review?(continuation)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → bzbarsky
Whiteboard: [need review]
Reporter | ||
Comment 5•12 years ago
|
||
Comment on attachment 702135 [details] [diff] [review] Make the asserts in nsWrapperCache.h fatal. Review of attachment 702135 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #702135 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/609b32dec10d
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla21
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/609b32dec10d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•