Make every single assert in nsWrapperCache.h fatal

RESOLVED FIXED in mozilla21

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: bz)

Tracking

unspecified
mozilla21
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
There are a few of these NS_ASSERTIONs in nsWrapperCache, and they all look pretty awful. bz had a problem that took us a long time to pin down because it wasn't clear where the problem was. We should make these into MOZ_ASSERT to catch problems earlier.  And possibly consider making them crash in release builds...
I think we should strongly consider making every single assert in nsWrapperCache.h fatal.
(Reporter)

Updated

5 years ago
Summary: Make !PreservingWrapper() into fatal assertions in nsWrapperCache → Make every single assert in nsWrapperCache.h fatal
Andrew, are you taking this, or should I?  I have most of this patch already....  Would need to run it through try, I guess.
(Reporter)

Comment 3

5 years ago
I haven't started on it. Feel free to do it if you want, or I can probably get to it in a day or two.
Created attachment 702135 [details] [diff] [review]
Make the asserts in nsWrapperCache.h fatal.

Try run at https://tbpl.mozilla.org/?tree=Try&rev=17680b7ab2c0
Attachment #702135 - Flags: review?(continuation)
Assignee: nobody → bzbarsky
Whiteboard: [need review]
(Reporter)

Comment 5

5 years ago
Comment on attachment 702135 [details] [diff] [review]
Make the asserts in nsWrapperCache.h fatal.

Review of attachment 702135 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #702135 - Flags: review?(continuation) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/609b32dec10d
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla21

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/609b32dec10d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.