830572 - [Settings] "Manage networks": MAC address label overlaps value

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Reuben Morais [:reuben]]

Attachment: Screenshot

This overlaps in English, the chart in http://www.economist.com/node/21551466 gives a pretty good idea of what happens in es and pt-BR.

Comment 1

[Axel Hecht [:Pike]]

It'd be good if we could get the actual MAC address into its own line, similar what we do for the connection status in the screenshot.

Comment 2

[Clauber Stipkovic [:cstipkovic]]

I'm testing on a geeksphone device, using it in pt-br, and this bug happens there too, and it is more visible then the en-us version.

Comment 3

[Leo]

Github URL
https://github.com/mozilla-b2g/gaia/pull/8114
https://github.com/leob2g/gaia/commit/459d76c89dd1a7f7381f6b76f82cb3bd111b5ea1

Comment 4

[Leo]

Attachment: link to path on github

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 716911 [details]
link to path on github

Also I would like a UX stamp for that. Because a different solution could be to change the english strings.

Comment 6

[Sam Joch [:samjoch]]

Comment on attachment 716911 [details]
link to path on github

the PR is not clear. 

[e-mail]: Can you PR one commit per bug number ?

Comment 7

[Leo]

Attachment: New patch (separate pull requests)

I reuploaded patch

Comment 9

[Alex Keybl [:akeybl]]

Daniel - is this an important support issue for you all? If not, I'd suggest we not block on this.

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

the UI is totally broken though, if this is not an important feature, the whole Mac address UI should be removed

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

change to + by accident. leave it leo? until we have feedback from dcoloma

Comment 12

[Daniel Coloma:dcoloma]

I do not think operators use that info for support purposes. I think this is mostly used by users who want to restrict their home WiFis only to a subset of MAC addresses.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Proposed change to show the MAC address in the 'Manage networks' view the same way as one line each for label and value as in the 'More information' sub view of the 'Device information': https://github.com/mozilla-b2g/gaia/pull/8970

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Not a blocker then since this is polish, but marking tracking so the fix can be nominated for uplift.

Comment 15

[Fabien Cazenave [:kaze]]

Comment on attachment 718713 [details]
New patch (separate pull requests)

This is the markup we should get:
          <li>
            <small data-name="deviceinfo.mac"></small>
            <span data-l10n-id="macAddress"> MAC address </span>
          </li>

and it looks like this markup is already like that in the master branch. I’ll try to find the original patch and uplift it.

Comment 16

[Fabien Cazenave [:kaze]]

OK, I’ve just merged Archaeopteryx’s patch on master:
https://github.com/mozilla-b2g/gaia/commit/d0d350489a63bd01c57c1e2ce38c758739073221

Comment 17

[Alex Keybl [:akeybl]]

a=akeybl to uplift the patch to v1.1. What is that patch?

Comment 18

[Fabien Cazenave [:kaze]]

That’s the patch proposed by Archaeopteryx on comment #13
https://github.com/mozilla-b2g/gaia/pull/8970

Comment 19

[Fabien Cazenave [:kaze]]

uplifted to v1-train:
https://github.com/mozilla-b2g/gaia/commit/3da1c04695e5f4562497c9996d21283fbc2cf68a