830696 - B2G STK: provide more information about STK_CMD_SET_UP_CALL to gaia

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Edgar Chen [:edgar]]

According to 3GPP TS 11.14, section 12.6, the command qualifier can indicate the following:

SET UP CALL:
'00' = set up call, but only if not currently busy on another call;
'01' = set up call, but only if not currently busy on another call, with redial;
'02' = set up call, putting all other calls (if any) on hold;
'03' = set up call, putting all other calls (if any) on hold, with redial;
'04' = set up call, disconnecting all other calls (if any);
'05' = set up call, disconnecting all other calls (if any), with redial;
'06' to 'FF' = reserved values.

We shall provide this information to gaia.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Part 1: IDL for SET_UP_CALL, v1

IDL patch

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 2: Expose more info about SET_UP_CALL in RIL, v1

RIL implementation

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part 3: xpcshell tests for SET_UP_CALL, v1

xpcshell tests

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part 4: marionette tests for SET_UP_CALL, v1

marionette tests

Comment 5

[Edgar Chen [:edgar]]

Hi Carol,

From the comment of RIL_REQUEST_STK_HANDLE_CALL_SETUP_REQUESTED_FROM_SIM in hardware/ril/include/telephony/ril.h [1]

'When STK application gets RIL_UNSOL_STK_CALL_SETUP, the call actually has been initialized by ME already. (We could see the call has been in the 'call list') So, STK application needs to accept/reject the call according as user operations.'

It seems gaia only needs to pass user confirmation to gecko, then gecko reports to modem by 'RIL_REQUEST_STK_HANDLE_CALL_SETUP_REQUESTED_FROM_SIM'.
Actually the implementation of Android is the same.

So I think the action of comment #0 shall be handled by modem or proprietary.

Could you help to confirm about this?

If anything wrong, please correct me. :)

Thanks

[1] https://github.com/EdgarChen/platform_hardware_ril/blob/master/include/telephony/ril.h#L2531

Comment 6

[Edgar Chen [:edgar]]

Attachment: Part 2: Expose more info about SET_UP_CALL in RIL, v2

The callMessage will be fixed in bug 831183.

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 702679 [details] [diff] [review]
Part 1: IDL for SET_UP_CALL, v1

Wait feedback (comment #5). So, cancel review first.

Comment 8

[Andrew Overholt [:overholt]]

This blocks something which is tef+ which in turn blocks bug 808607.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

if cyang is not available, could anshulj or mvines confirm comment 5?

Comment 10

[Anshul]

Edgar, you are right that Gaia doesn't need to handle the command qualifiers. We have confirmed the same with Android. You can close this bug.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

As modem can handle this, I close this as WONTFIX.