Open Bug 830718 Opened 7 years ago Updated 8 months ago

Reenable private browsing notification xpcshell tests

Categories

(Firefox :: Private Browsing, defect)

x86_64
Linux
defect
Not set

Tracking

()

People

(Reporter: jdm, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Now that the notification is synchronous with docshells being destroyed, as opposed to requiring garbage collection, we should be able to reenable these tests that would frequently time out.

test_pb_notification.js
test_pb_notification_ipc.js
Blocks: pbngentest
Attached patch Patch (v1)Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=a10304ed437e
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #706250 - Flags: review?(josh)
Comment on attachment 706250 [details] [diff] [review]
Patch (v1)

Review of attachment 706250 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is fine, but the try run shows that the IPC test times out. I'll look into it.
Attachment #706250 - Flags: review?(josh) → review+
Flags: needinfo?(josh)
Any updates here, Josh?
Assignee: ehsan → josh
Looking at the results again, now that xpcshell tests that time out show the rest of the log.

https://tbpl.mozilla.org/?tree=Try&rev=56a06b64e67f
Flags: needinfo?(josh)
OS X timed out. I wonder if there's something about the hidden window...

https://tbpl.mozilla.org/?tree=Try&rev=44ae10d4b2c7
Assignee: josh → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.