830718 - Reenable private browsing notification xpcshell tests

Status: NEW

(Firefox :: Private Browsing, defect)

Description

[Josh Matthews [:jdm]]

Now that the notification is synchronous with docshells being destroyed, as opposed to requiring garbage collection, we should be able to reenable these tests that would frequently time out.

test_pb_notification.js
test_pb_notification_ipc.js

Comment 1

[(no longer active)]

Attachment: Patch (v1)

https://tbpl.mozilla.org/?tree=Try&rev=a10304ed437e

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 706250 [details] [diff] [review]
Patch (v1)

Review of attachment 706250 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is fine, but the try run shows that the IPC test times out. I'll look into it.

Comment 3

[(no longer active)]

Any updates here, Josh?

Comment 4

[Josh Matthews [:jdm]]

Looking at the results again, now that xpcshell tests that time out show the rest of the log.

https://tbpl.mozilla.org/?tree=Try&rev=56a06b64e67f

Comment 5

[Josh Matthews [:jdm]]

OS X timed out. I wonder if there's something about the hidden window...

https://tbpl.mozilla.org/?tree=Try&rev=44ae10d4b2c7