Closed Bug 830757 Opened 11 years ago Closed 11 years ago

Jank from main thread SQL degrades download experience

Categories

(Core Graveyard :: File Handling, defect)

21 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 825588

People

(Reporter: vladan, Unassigned)

References

()

Details

(Keywords: main-thread-io, Whiteboard: [Snappy])

I hit jank whenever I open a download with an external app. For example, when I click on the video attached to bug 794246, I get roughly a 1 second UI pause.

Profile shows we're doing main thread SQL from nsDownload::UpdateDB:

http://people.mozilla.com/~bgirard/cleopatra/#report=ed51003641c2c93254aa1596b829519e0c293ab9

I think this is the offending SQL:

UPDATE moz_downloads SET tempPath = :tempPath, startTime = :startTime, endTime = :endTime, state = :state, referrer = :referrer, entityID = :entityID, currBytes = :currBytes, maxBytes = :maxBytes, autoResume = :autoResume WHERE id = :id /* downloads.sqlite */

P.S. Ignore the incorrect "shutdown" markers & the main thread I/O from the DropBox extension in the profile.
Depends on: asyncDownloadMgr
Status: NEW → RESOLVED
Closed: 11 years ago
No longer depends on: asyncDownloadMgr
Resolution: --- → DUPLICATE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.