Remove JSScript::principals

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: bholley, Assigned: billm)

Tracking

unspecified
mozilla21
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It's not clear to me how this could ever be anything sane except the compartment principals. I think we should remove it, unless anyone knows something that I don't.

We probably need to keep originPrincipals for now, though.
Sounds good.  Perhaps we can assert, on script creation, that whatever principle was passed is equivalent to compartment->principle?
This is a pretty conservative patch. Once we've given the assertions some time, we'll be able to remove more code.

I left the field in as padding, but I'm planning to use it for zones pretty soon.

https://tbpl.mozilla.org/?tree=Try&rev=d9ddc605aa59
Assignee: bobbyholley+bmo → wmccloskey
Status: NEW → ASSIGNED
Attachment #706184 - Flags: review?(luke)
Attachment #706184 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/25c7af76b274
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.