830855 - Remove JSScript::principals

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bobby Holley (:bholley)]

It's not clear to me how this could ever be anything sane except the compartment principals. I think we should remove it, unless anyone knows something that I don't.

We probably need to keep originPrincipals for now, though.

Comment 1

[Luke Wagner [:luke]]

Sounds good.  Perhaps we can assert, on script creation, that whatever principle was passed is equivalent to compartment->principle?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: rm script->principals

This is a pretty conservative patch. Once we've given the assertions some time, we'll be able to remove more code.

I left the field in as padding, but I'm planning to use it for zones pretty soon.

https://tbpl.mozilla.org/?tree=Try&rev=d9ddc605aa59

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25c7af76b274

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25c7af76b274