Last Comment Bug 830871 - Unfriend js_GetClassPrototype
: Unfriend js_GetClassPrototype
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla21
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-15 10:37 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2013-01-17 02:52 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (745 bytes, patch)
2013-01-15 10:37 PST, Jeff Walden [:Waldo] (remove +bmo to email)
jorendorff: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2013-01-15 10:37:28 PST
Created attachment 702415 [details] [diff] [review]
Patch

We want to get rid of JSProtoKey as part of the JSAPI eventually, and this stands in the way.  Plus it's not used outside js/src.

http://mxr.mozilla.org/mozilla-central/search?string=js_GetClassPrototype&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2013-01-15 10:39:16 PST
...and I apparently filed bug 725888 to do exactly this, and if I look at the change rev there, I removed it from jsfriendapi.h and added it to jsobj.h -- preserving the friend-API-ness of it.  I have no idea why I did this.
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2013-01-16 17:04:03 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e3ecf55210d
Comment 3 Ed Morley [:emorley] 2013-01-17 02:52:38 PST
https://hg.mozilla.org/mozilla-central/rev/2e3ecf55210d

Note You need to log in before you can comment on or make changes to this bug.