830905 - "Add to homescreen" is broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Open browser
 (2) Go to soso.com
 (3) Tap star icon, then "Add to homescreen"

Nothing happens.  Nothing in logcat.

$ (cd gecko/ && git rev-parse HEAD && cd ../gaia && git rev-parse HEAD)
f02c5c070c9b4e589cfa23c17a76c1eafe840947
a03f7b532e9998e646d55f93a0fc03a04d7ca7d9

Broken feature, obvious blocker (however we're counting them).

Comment 1

[Marcia Knous [:marcia]]

Same is true of e.me. This was working in the first build out this morning that was still dated the 14th.

Comment 2

[Cristian Rodriguez (:crdlc)]

window.open does not return the window called 'name' [1] in order to send the 'ADD_BOOKMARK' message to homescreen app

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/bookmark.js#L78

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

this may have something to do with : bug 804824

Comment 4

[Daniel Coloma:dcoloma]

this is a critical feature, what is the regression window for this one?

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Home page works on this build:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/a4f51b077734
Gaia   9d4983b18d5ff79b5900a8075d38eea352635728
BuildID 20130111112953
Version 18.0

I'll have to narrow the window down a little further.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

to note : bug 804824 was a separate issue.  The build in comment 5 shows home screen on m.soso.com.

Comment 7

[Ben Francis [:benfrancis]]

The code that was added to turn this into an inline activity which was working, is now no longer working https://github.com/mozilla-b2g/gaia/commit/3b3276f7726238d2e5170dd91c781b3c8e89bc35

As crdlc says, this is because it's expecting window.open('', 'main'); to return the main Window object of the homescreen app but it is in fact returning null. That results in there being no window object on which to send the postMessage which triggers the actual saving to homescreen.

I've yet to figure out why this is.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Still working on :

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/f2460bf17811
Gaia   df38c1bb813029f3ccfa4a997fb1529b3ff1a1ff
BuildID 20130114230201
Version 18.0

Broken:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/0a7c51803227
Gaia   a03f7b532e9998e646d55f93a0fc03a04d7ca7d9
BuildID 20130115230201
Version 18.0

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This is broken as well:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/67503cae6a5a
Gaia   a03f7b532e9998e646d55f93a0fc03a04d7ca7d9
BuildID 20130115070201
Version 18.0

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Patch v1

This bug is a side effect resulted from the resolution of bug 824677. It assigned the name of the window to a wrong object and that's why we are unable to get the correct window object using window.open. The proposed patch simply fixes it.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 703155 [details]
Patch v1

r=me.

Please add a comment before that line why we need to set the attribute for app iframe.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Let's land it since it's already tef+

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Fixed. https://github.com/mozilla-b2g/gaia/commit/9cbe94ede33d6247320decdf79ab0fd9a75fc95a

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Land on v1.0.0. https://github.com/mozilla-b2g/gaia/commit/672209502c2f8e8e6df7ab160d2df70e46c20959

Comment 17

[Askeing Yen[:askeing][:fyen]]

Gaia:
  Rev     7cacbcb8042b49d816a34de8e9767dcedefa6d84
  B-D     2013-01-25 02:57:10
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/32c2cc3e19ff
BuildID   20130124140859
Version   18.0

Verified.

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.