Closed Bug 830908 Opened 9 years ago Closed 9 years ago

Fix webrtc.org GetThreadID return size (upstream bug)

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

17 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jesup, Assigned: jesup)

References

(Depends on 1 open bug)

Details

(Whiteboard: [WebRTC] [blocking-webrtc+] [qa-])

Attachments

(1 file, 2 obsolete files)

ThreadWrapper::GetThreadId() in the webrtc code imported from stable branch 3.20 returns a uint32_t; this causes a build failure on Mac builders due to warning about possible dataloss.

Patch bumps it to uint64_t to avoid platform-specific differences.

Needs to be fixed upstream
No longer blocks: 830247
Depends on: 830247
Depends on: webrtc_updates
Attachment #702441 - Flags: review?(ekr)
Comment on attachment 702441 [details] [diff] [review]
Fix GetThreadID return size (upstream bug)

Review of attachment 702441 [details] [diff] [review]:
-----------------------------------------------------------------

this is kinda gross, but I guess better than before
Attachment #702441 - Flags: review?(ekr) → review+
Attachment #702441 - Attachment is obsolete: true
Assignee: nobody → rjesup
Priority: -- → P1
Whiteboard: [WebRTC] [blocking-webrtc+]
Comment on attachment 702635 [details] [diff] [review]
Fix GetThreadID return size (upstream bug)

carry r+=ekr forward
Attachment #702635 - Flags: review+
Attachment #702635 - Flags: checkin?(rjesup)
Will land with 3.20
import patch from Webrtc.org to avoid having to merge later
Comment on attachment 712195 [details] [diff] [review]
Thread intsize patch uplifted from webrtc.org

in-person r=derf
Attachment #712195 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/54960ffc951b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [WebRTC] [blocking-webrtc+] → [WebRTC] [blocking-webrtc+] [qa-]
Attachment #702635 - Flags: checkin?(rjesup)
Attachment #702635 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.