Closed
Bug 830908
Opened 13 years ago
Closed 13 years ago
Fix webrtc.org GetThreadID return size (upstream bug)
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Whiteboard: [WebRTC] [blocking-webrtc+] [qa-])
Attachments
(1 file, 2 obsolete files)
|
1.09 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
ThreadWrapper::GetThreadId() in the webrtc code imported from stable branch 3.20 returns a uint32_t; this causes a build failure on Mac builders due to warning about possible dataloss.
Patch bumps it to uint64_t to avoid platform-specific differences.
Needs to be fixed upstream
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Updated•13 years ago
|
Depends on: webrtc_updates
|
|
Assignee | |
Comment 2•13 years ago
|
||
Use 1299 for webrtc.org:
http://code.google.com/p/webrtc/issues/detail?id=1299
|
|
Assignee | |
Updated•13 years ago
|
Attachment #702441 -
Flags: review?(ekr)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 702441 [details] [diff] [review]
Fix GetThreadID return size (upstream bug)
Review of attachment 702441 [details] [diff] [review]:
-----------------------------------------------------------------
this is kinda gross, but I guess better than before
Attachment #702441 -
Flags: review?(ekr) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #702441 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → rjesup
Priority: -- → P1
Whiteboard: [WebRTC] [blocking-webrtc+]
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 702635 [details] [diff] [review]
Fix GetThreadID return size (upstream bug)
carry r+=ekr forward
Attachment #702635 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #702635 -
Flags: checkin?(rjesup)
|
|
Assignee | |
Comment 6•13 years ago
|
||
Will land with 3.20
|
||
Comment 7•13 years ago
|
||
Fixed upstream in https://webrtc-codereview.appspot.com/1063005/,
though http://code.google.com/p/webrtc/issues/detail?id=1299 is still open.
|
|
Assignee | |
Comment 8•13 years ago
|
||
import patch from Webrtc.org to avoid having to merge later
|
|
Assignee | |
Comment 9•13 years ago
|
||
Comment on attachment 712195 [details] [diff] [review]
Thread intsize patch uplifted from webrtc.org
in-person r=derf
Attachment #712195 -
Flags: review+
|
|
Assignee | |
Comment 10•13 years ago
|
||
Target Milestone: --- → mozilla21
|
||
Comment 11•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc+] → [WebRTC] [blocking-webrtc+] [qa-]
|
|
Assignee | |
Updated•13 years ago
|
Attachment #702635 -
Flags: checkin?(rjesup)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #702635 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•