830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Anton Kovalyov (:anton)]

If you start a profiler and then stop it, Firefox still outputs stuff like "MOZ_EVENT_TRACE sample 1358286962225 20" which means that event tracer is still running. BenWa on IRC suggested that we need to turn off event tracer together with the profiler.

Comment 2

[Markus Stange [:mstange]]

ThreadResponsiveness starts dispatching CheckResponsivenessEvents the first time ThreadResponsiveness::Update is called, and only stops doing so in the ~ThreadResponsiveness destructor. The ThreadResponsiveness object is stored in a field of the main thread's ThreadInfo object, and is only destroyed once the profiler shuts down.
We could fix this by notifying ThreadInfo when the profiler is started + stopped, and .emplace() and .reset() mResponsiveness at those times. (And we'd need to change the MOZ_ASSERT(!!responsiveness == mIsMainThread) assertion.)

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped.

Review commit: https://reviewboard.mozilla.org/r/130632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130632/

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8858652 [details]
Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130632/diff/1-2/

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8858652 [details]
Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130632/diff/2-3/

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 8858652 [details]
Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped.

https://reviewboard.mozilla.org/r/130632/#review133550

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8858652 [details]
Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130632/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d86f0c3ddd4
Stop dispatching CheckResponsivenessEvents when the profiler is stopped. r=njn

Comment 9

[Iris Hsiao [:ihsiao]]

backed out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=92208573&repo=autoland&lineNumber=5024

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 8858652 [details]
Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130632/diff/4-5/

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c487f6dc896
Backed out changeset 9d86f0c3ddd4 for build bustage

Comment 12

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2e6e8b354983 -d 5d3957c7d732: rebasing 390340:2e6e8b354983 "Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped. r=njn" (tip)
merging tools/profiler/core/ThreadInfo.cpp
merging tools/profiler/core/ThreadInfo.h
warning: conflicts while merging tools/profiler/core/ThreadInfo.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29cd64bf901f
Stop dispatching CheckResponsivenessEvents when the profiler is stopped. r=njn

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/29cd64bf901f