Stop dispatching CheckResponsivenessEvents when the profiler is stopped

RESOLVED FIXED in Firefox 55

Status

()

Core
Gecko Profiler
RESOLVED FIXED
4 years ago
6 days ago

People

(Reporter: anton, Assigned: mstange)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
If you start a profiler and then stop it, Firefox still outputs stuff like "MOZ_EVENT_TRACE sample 1358286962225 20" which means that event tracer is still running. BenWa on IRC suggested that we need to turn off event tracer together with the profiler.
(Reporter)

Updated

4 years ago
Duplicate of this bug: 832121
(Assignee)

Updated

4 months ago
Blocks: 1329212
(Assignee)

Comment 2

8 days ago
ThreadResponsiveness starts dispatching CheckResponsivenessEvents the first time ThreadResponsiveness::Update is called, and only stops doing so in the ~ThreadResponsiveness destructor. The ThreadResponsiveness object is stored in a field of the main thread's ThreadInfo object, and is only destroyed once the profiler shuts down.
We could fix this by notifying ThreadInfo when the profiler is started + stopped, and .emplace() and .reset() mResponsiveness at those times. (And we'd need to change the MOZ_ASSERT(!!responsiveness == mIsMainThread) assertion.)
Summary: Turn off event tracer when profiler is stopped → Stop dispatching CheckResponsivenessEvents when the profiler is stopped
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

7 days ago
mozreview-review
Comment on attachment 8858652 [details]
Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped.

https://reviewboard.mozilla.org/r/130632/#review133550
Attachment #8858652 - Flags: review?(n.nethercote) → review+
Comment hidden (mozreview-request)

Comment 8

6 days ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/9d86f0c3ddd4
Stop dispatching CheckResponsivenessEvents when the profiler is stopped. r=njn
backed out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=92208573&repo=autoland&lineNumber=5024
Flags: needinfo?(mstange)
Comment hidden (mozreview-request)
(Assignee)

Updated

6 days ago
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Flags: needinfo?(mstange)

Comment 11

6 days ago
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c487f6dc896
Backed out changeset 9d86f0c3ddd4 for build bustage

Comment 12

6 days ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2e6e8b354983 -d 5d3957c7d732: rebasing 390340:2e6e8b354983 "Bug 830990 - Stop dispatching CheckResponsivenessEvents when the profiler is stopped. r=njn" (tip)
merging tools/profiler/core/ThreadInfo.cpp
merging tools/profiler/core/ThreadInfo.h
warning: conflicts while merging tools/profiler/core/ThreadInfo.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 13

6 days ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/29cd64bf901f
Stop dispatching CheckResponsivenessEvents when the profiler is stopped. r=njn

Comment 14

6 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/29cd64bf901f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 days ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.