Closed Bug 831021 Opened 13 years ago Closed 12 years ago

Toolbar curve jumps 4px on tab slide animation

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

All
Android
defect
Not set
normal

Tracking

(firefox20 fixed, firefox21 fixed)

RESOLVED FIXED
Firefox 21
Tracking Status
firefox20 --- fixed
firefox21 --- fixed

People

(Reporter: shorlander, Assigned: sriram)

References

Details

Attachments

(2 files)

Attached image Curve Overlay
The curve on the toolbar during the slide animation doesn't line up with the curve in the default state. This creates a noticeable jump at the end of the animation. The offset appears to be about 4px.
/summon Sriram
Assignee: nobody → sriram
Attached patch PatchSplinter Review
Corrected the marginRight so that the curves match.
Attachment #714097 - Flags: review?(mark.finkle)
Attachment #714097 - Flags: review?(mark.finkle) → review+
Comment on attachment 714097 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Some regression somewhere. User impact if declined: Users will sharp eyes will find that we are overlapping when animation ends. Testing completed (on m-c, etc.): Landed in m-i on 02/14. Risk to taking this patch (and alternatives if risky): Very less. Just margin values changed. String or UUID changes made by this patch: None.
Attachment #714097 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Attachment #714097 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: