831021 - Toolbar curve jumps 4px on tab slide animation

Status: RESOLVED FIXED

(Firefox for Android :: Theme and Visual Design, defect)

Description

[Stephen Horlander [:shorlander] (If you're waiting on a response please ping me on Slack or IRC)]

Attachment: Curve Overlay

The curve on the toolbar during the slide animation doesn't line up with the curve in the default state. This creates a noticeable jump at the end of the animation.

The offset appears to be about 4px.

Comment 1

[Aaron Train [:aaronmt]]

/summon Sriram

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Corrected the marginRight so that the curves match.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1d92d4bf209

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 714097 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Some regression somewhere.
User impact if declined: Users will sharp eyes will find that we are overlapping when animation ends.
Testing completed (on m-c, etc.): Landed in m-i on 02/14.
Risk to taking this patch (and alternatives if risky): Very less. Just margin values changed.
String or UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1d92d4bf209

Comment 7

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/66dd13c06cdf