Closed
Bug 831021
Opened 11 years ago
Closed 11 years ago
Toolbar curve jumps 4px on tab slide animation
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox20 fixed, firefox21 fixed)
RESOLVED
FIXED
Firefox 21
People
(Reporter: shorlander, Assigned: sriram)
References
Details
Attachments
(2 files)
24.21 KB,
image/png
|
Details | |
4.42 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The curve on the toolbar during the slide animation doesn't line up with the curve in the default state. This creates a noticeable jump at the end of the animation. The offset appears to be about 4px.
Comment 1•11 years ago
|
||
/summon Sriram
Updated•11 years ago
|
status-firefox20:
--- → affected
status-firefox21:
--- → affected
Updated•11 years ago
|
Assignee: nobody → sriram
Assignee | ||
Comment 3•11 years ago
|
||
Corrected the marginRight so that the curves match.
Attachment #714097 -
Flags: review?(mark.finkle)
Updated•11 years ago
|
Attachment #714097 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1d92d4bf209
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 714097 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Some regression somewhere. User impact if declined: Users will sharp eyes will find that we are overlapping when animation ends. Testing completed (on m-c, etc.): Landed in m-i on 02/14. Risk to taking this patch (and alternatives if risky): Very less. Just margin values changed. String or UUID changes made by this patch: None.
Attachment #714097 -
Flags: approval-mozilla-aurora?
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e1d92d4bf209
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Updated•11 years ago
|
Attachment #714097 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/66dd13c06cdf
Updated•11 years ago
|
Updated•11 years ago
|
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•