831023 - On non-Mac platforms: gfx/layers/opengl/CanvasLayerOGL.cpp:89:1: warning: 'GLuint MakeIOSurfaceTexture(void*, mozilla::gl::GLContext*)' defined but not used [-Wunused-function]

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
gfx/layers/opengl/gfx/layers/opengl/CanvasLayerOGL.cpp:89:1: warning: 'GLuint MakeIOSurfaceTexture(void*, mozilla::gl::GLContext*)' defined but not used [-Wunused-function]

This function has an interesting definition in an #ifdef XP_MAC clause, and then a trivial impl in an #else clause.  And then it's only called once, in some #ifdef XP_MAC code.

Two easy solutions: 
  (1) Drop the whole #else clause, since it's unused
 ...or...
  (2) Declare the function as inline instead of static. It's only called once, so inlining it shouldn't be expensive. (and inline functions don't trigger -Wunused-function.)


Note that prior to bug 724666, this function was completely unused. (as reported in bug 797616 and bug 786057)  Now it's just unused-on-non-mac-platforms.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

I'm leaning towards just removing the non-mac version of this function, because it's just a NS_RuntimeAbort anyway. (and it's probably better to catch non-Mac-platform usages of this function at compile time rather than at run time.)

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 702539 [details] [diff] [review]
fix v1

That works, thanks

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb97ca612605

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bb97ca612605