831191 - nsPNGEncoder doesn't understand 16bpp surfaces

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This makes using the fantastically useful gfxASurface::Dump*() helpers impossible.

244   // Stride is the padded width of each row, so it better be longer 
245   // (I'm afraid people will not understand what stride means, so
246   // check it well)
247   if ((aInputFormat == INPUT_FORMAT_RGB &&
248       aStride < aWidth * 3) ||
249       ((aInputFormat == INPUT_FORMAT_RGBA ||
250       aInputFormat == INPUT_FORMAT_HOSTARGB) &&
251       aStride < aWidth * 4)) {
252     NS_WARNING("Invalid stride for InitFromData/AddImageFrame");
253     return NS_ERROR_INVALID_ARG;
254   }

Will hack around this for now.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Hack

Running this up the flagpole and seeing if anyone salutes it.  Don't have time for a real fix.

Comment 2

[Joe Drew (not getting mail)]

Comment on attachment 702719 [details] [diff] [review]
Hack

Review of attachment 702719 [details] [diff] [review]:
-----------------------------------------------------------------

:(

Can you file a followup bug so we can actually fix this correctly?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Filed followup and left FIXME comment

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae928c1ca2dc

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/ae928c1ca2dc