831203 - Pass keyboard language to e.me API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Evyatar 'Tron' Amitay (everything.me)]

Everything.me's API needs to be aware of the user's keyboard language to bring accurate results.

There are a lot of the same characters in English and European languages, so you can't always tell the language just by parsing the query.

Comment 1

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Added a new moz settings - keyboard.current.
gave keyboard write permissions (to set this value).
added a settings observer on e.me.

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 702744 [details]
Patch - redirect to github PR

I cannot review the keyboard app, ask for this review to Rudy for example

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

sure, which Rudy is that?

Comment 4

[Cristian Rodriguez (:crdlc)]

https://github.com/RudyLu

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 702744 [details]
Patch - redirect to github PR

r+ from me for the keyboard part if the lint/nits are addressed.
I did not review the everything.me part since I am not familiar with that.

Thanks.

Comment 6

[Evyatar 'Tron' Amitay (everything.me)]

pushed an updated version- fixed keyboard.js lint issues (and finally set up my IDE to work with the correct lint settings for the gaia repo).

cristian- can you take a look at the e.me part? nothing too serious, just to make sure I didn't miss any anonymous functions :)

Comment 7

[Cristian Rodriguez (:crdlc)]

it is ok ;)

Comment 8

[Evyatar 'Tron' Amitay (everything.me)]

Ok, so now just the approval from Francisco?

Francisco- do I need anyone else's approval on this? asking cause it's the first time I've added a patch that affects other apps outside e.me, so I want to make sure it's all ok.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 702744 [details]
Patch - redirect to github PR

Needed change for the correct behaviour of e.me

Rudy approved the changes on the keyboard side, I've been taking a look to the changes looking good to me and trying it on the phone, looking good as well.

a=me

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/78dc0c3cb0747a26a0839c7660b7fa6a5cf5049a