831274 - [COST CONTROL] Application does not start properly when no SIM is inserted

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

STR:
1 - Remove the SIM
2 - Open the CC application

Expected:
Applications starts showing only data usage tab.

Actual:
UI breaks and nothing is displayed nor usable

Comment 1

[David Scravaglieri [:scravag]]

Daniel, Salva, we agree this is important and if a user wants to know his data usage without having a sim card inserted, it looks crappy. We don't think it should blocks. We need your advice.

Comment 2

[Salvador de la Puente González [:salva]]

We should block on this, at least to provide a dialog saying "CC application don't work without SIM" but the UI must not crash under any circumstance or possible case.

Comment 3

[Daniel Coloma:dcoloma]

As Salva says, UI is crashing, this should be a tef+.

Comment 4

[Salvador de la Puente González [:salva]]

A NO-SIM scenario should be contemplated but I'm not providing new functionality for this scenario. These specifications came too late so, in order to keep Cost Control stable, I'm removing the functionality replacing it by a dialog saying you need a SIM to enable Cost Control.

Do you agree Dani?

Comment 5

[Salvador de la Puente González [:salva]]

Attachment: Widget view when NO-SIM

Please Marco, review the texts for the widget when no SIM is inserted.

Comment 6

[Salvador de la Puente González [:salva]]

Attachment: Application view when NO-SIM

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 703830 [details]
Application view when NO-SIM

This is what is viewed if the user tries to open Cost Control application when no sim is inserted. If the user press Ok, the application closes itselg.

Comment 8

[Daniel Coloma:dcoloma]

Agree, if the no-SIM scenario is not implemented, at this stage is better not allowing it and that's it.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 703829 [details]
Widget view when NO-SIM

There isn't a whole lot for us to review here yet, but I don't spot anything bad here or in the app screen.

PS: :l10n is an alias, better to request review from me (:Pike) or :stas directly.

Comment 10

[Salvador de la Puente González [:salva]]

Attachment: Removing NO-SIM scenario due to lack of maturity

It has been necessary to bump some l10n strings. As they are used dynamically on code, this code has been modified as well.

Comment 11

[Salvador de la Puente González [:salva]]

Comment on attachment 703833 [details]
Removing NO-SIM scenario due to lack of maturity

Please, let's delay the landing on this until Marco review the strings for l10n.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 703833 [details]
Removing NO-SIM scenario due to lack of maturity

js looking good to me, tried on the phone and working pretty cool.

Adding :stas to the review as this patch contains modifications to the strings.

Thanks!

Comment 13

[marcoc]

(In reply to Salvador de la Puente González [:salva] from comment #11)
> Comment on attachment 703833 [details]
> Removing NO-SIM scenario due to lack of maturity
> 
> Please, let's delay the landing on this until Marco review the strings for
> l10n.

String text to be:

No SIM inserted
Insert a SIM to enable Usage

Comment 14

[Salvador de la Puente González [:salva]]

Comment on attachment 703833 [details]
Removing NO-SIM scenario due to lack of maturity

Updated with Marco's feedback.

Comment 15

[Salvador de la Puente González [:salva]]

master:
https://github.com/mozilla-b2g/gaia/commit/02c1231694e9d001fa1323e4b8838fd2ad47dc86

v1.0.0:
https://github.com/mozilla-b2g/gaia/commit/2a5cbfdc252aaa1d74d34e8fd3b4571d29276254

Comment 16

[Walter Chen[:ypwalter][:wachen]]

Verified fixed in pvt b2g18 user build.

Gaia:
  Rev     7cacbcb8042b49d816a34de8e9767dcedefa6d84
  B-D     2013-01-25 02:57:10
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/32c2cc3e19ff
BuildID   20130124140859
Version   18.0

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.