Closed Bug 831299 Opened 12 years ago Closed 3 months ago

Ionmonkey: Inline more of js::ion::NewGCThing

Categories

(Core :: JavaScript: GC, defect)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: h4writer, Unassigned)

References

Details

Currently we do a OOL VMCall when arena is empty. This happens in raytrace 1 out of 62 times. We could add an ool path (not vm) to pull a new arena in GC's freelists. Than we can stay in jitcode, except in cases where there are no arenas available at all, and we need to GC or allocate a new chunk. Currently the time spend in the OOL VMCall is 3% of raytrace. The OOL path will probably be much faster and almost remove the total time.
Blocks: 768745
This has the potential to be quite hard because of the background sweep thread, but would be a nice stopgap until we get Generational GC. And even with a fully-tuned GGC, this will still be useful for shapes and anything else we can't nursery allocate.
Assignee: general → nobody
Severity: normal → S3

Is this bug still relevant?

Component: JavaScript Engine → JavaScript: GC
Flags: needinfo?(jcoppeard)

We have generational GC now and the allocation paths for that are inlined so this is no longer relevant.

Status: NEW → RESOLVED
Closed: 3 months ago
Flags: needinfo?(jcoppeard)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.