Closed
Bug 831342
Opened 12 years ago
Closed 12 years ago
warnings about rollups (rollupWidget) too noisy (OS X)
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox19 | - | --- |
People
(Reporter: mak, Assigned: abr)
References
Details
(Keywords: regression, Whiteboard: [leave open])
Attachments
(1 file)
2.04 KB,
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #826115 +++ There are some noisy warnings emanating from the NS_ENSURE_TRUE(rollupWidget, false); line in nsWindow.cpp and in corresponding files for other platforms. If that's not an exceptional condition, we should just be doing `if (!rollupWidget) return false;`.
Comment 2•12 years ago
|
||
Simply copying the OS X patch from bug 826115 (see comment 1) over here... please can we stop spamming the terminal with this message in debug builds!
Attachment #706349 -
Flags: review?(smichaud)
Comment 3•12 years ago
|
||
(Adam, this is just your patch from 826115; I assume it'd be fine to go ahead and get this reviewed and landed here, as that bug was closed after fixing only the Windows case. This patch has been working fine for me - provided I remember to include it in my builds.)
Assignee | ||
Comment 4•12 years ago
|
||
Sorry for taking so long to circle back around to this -- I didn't have time to track down the cause of the crashes this was triggering when I first wrote it. In any case, it does appear to apply and run cleanly. For an abundance of caution, I'm pushing it to try and running a handful of tests on it to make sure the crash doesn't reappear with more rigorous activity: https://tbpl.mozilla.org/?tree=Try&rev=f36e6dd9a7bf I'll watch for Steven's review, and request checkin when he r+'s this.
Comment 5•12 years ago
|
||
Comment on attachment 706349 [details] [diff] [review] remove noisy NS_ENSURE... statements for rollupWidget on OS X This looks good. I frankly never use debug builds -- even without this spam they're too noisy for me. (Instead I add my own debug logging to non-debug builds as needed to resolve particular bugs.)
Attachment #706349 -
Flags: review?(smichaud) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #706349 -
Flags: checkin?(jmathies)
![]() |
||
Updated•12 years ago
|
Attachment #706349 -
Flags: checkin?(jmathies)
Comment 8•12 years ago
|
||
It's not clear that there's any user impact here, and the tracking flag came over from the clone - untracking.
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•