831342 - warnings about rollups (rollupWidget) too noisy (OS X)

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Marco Bonardo [:mak]]

+++ This bug was initially created as a clone of Bug #826115 +++

There are some noisy warnings emanating from the

  NS_ENSURE_TRUE(rollupWidget, false);

line in nsWindow.cpp and in corresponding files for other platforms.  If that's not an exceptional condition, we should just be doing `if (!rollupWidget) return false;`.

Comment 1

[Marco Bonardo [:mak]]

patch in https://bugzilla.mozilla.org/attachment.cgi?id=697949

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: remove noisy NS_ENSURE... statements for rollupWidget on OS X

Simply copying the OS X patch from bug 826115 (see comment 1) over here... please can we stop spamming the terminal with this message in debug builds!

Comment 3

[Jonathan Kew [:jfkthame]]

(Adam, this is just your patch from 826115; I assume it'd be fine to go ahead and get this reviewed and landed here, as that bug was closed after fixing only the Windows case. This patch has been working fine for me - provided I remember to include it in my builds.)

Comment 4

[Adam Roach [:abr]]

Sorry for taking so long to circle back around to this -- I didn't have time to track down the cause of the crashes this was triggering when I first wrote it. In any case, it does appear to apply and run cleanly. For an abundance of caution, I'm pushing it to try and running a handful of tests on it to make sure the crash doesn't reappear with more rigorous activity:

https://tbpl.mozilla.org/?tree=Try&rev=f36e6dd9a7bf

I'll watch for Steven's review, and request checkin when he r+'s this.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 706349 [details] [diff] [review]
remove noisy NS_ENSURE... statements for rollupWidget on OS X

This looks good.

I frankly never use debug builds -- even without this spam they're too noisy for me.  (Instead I add my own debug logging to non-debug builds as needed to resolve particular bugs.)

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b0e2838fa04

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b0e2838fa04

Comment 8

[Alex Keybl [:akeybl]]

It's not clear that there's any user impact here, and the tracking flag came over from the clone - untracking.