_virtualenv and mozilla/_virtualenv in each c-c objdir

RESOLVED FIXED in Thunderbird 22.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
Thunderbird 22.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
c-c configure adds _virtualenv to the objdir and then m-c configure adds it to its objdir/mozilla subdir. We can avoid the duplication by making c-c configure build objdir/mozilla/_virtualenv directly.
(Assignee)

Comment 1

5 years ago
Created attachment 703021 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #703021 - Flags: review?(bugspam.Callek)
Comment on attachment 703021 [details] [diff] [review]
Proposed patch

Review of attachment 703021 [details] [diff] [review]:
-----------------------------------------------------------------

I'd actually prefer you modify http://mxr.mozilla.org/comm-central/source/mozilla/build/autoconf/python-virtualenv.m4#50 (get m-c build peer review) and then use that here, the same way its used in m-c configure. Also to mark the creation script as a config dep in client.mk.

We can then even output the NO_POPULATE var to save work. The trick of course is making sure comm can find the venv inside m-c easily :-)
Attachment #703021 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 3

5 years ago
(In reply to Justin Wood from comment #2)
> I'd actually prefer you modify
> http://mxr.mozilla.org/comm-central/source/mozilla/build/autoconf/python-
> virtualenv.m4#50 (get m-c build peer review) and then use that here, the
> same way its used in m-c configure.
Ah, so you want me to include that script in c-c aclocal.m4?

> Also to mark the creation script as a config dep in client.mk.
We don't actually do that, we only mark aclocal.m4 as a config dep...

> We can then even output the NO_POPULATE var to save work. The trick of
> course is making sure comm can find the venv inside m-c easily :-)
I guess I'll just make c-c configure set MOZILLA_CENTRAL_PATH.
(Assignee)

Comment 4

5 years ago
Created attachment 708278 [details] [diff] [review]
Possible patch
Attachment #708278 - Flags: feedback?(mh+mozilla)
Comment on attachment 708278 [details] [diff] [review]
Possible patch

Review of attachment 708278 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like that should work.
Attachment #708278 - Flags: feedback?(mh+mozilla) → feedback+
(Assignee)

Updated

5 years ago
Attachment #708278 - Flags: review?(bugspam.Callek)
Attachment #708278 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 6

5 years ago
Pushed comm-central changeset fb586ffef6e8.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Does this checkin have to do with the current red on the SeaMonkey tree? It looks a bit related.
Target Milestone: --- → Thunderbird 21.0
Target Milestone: Thunderbird 21.0 → Thunderbird 22.0
You need to log in before you can comment on or make changes to this bug.