Closed Bug 831628 Opened 7 years ago Closed 7 years ago

B2G STK: Support "Idle Screen Available Event" Envelope command

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: allstars.chh, Assigned: chucklee)

References

Details

Attachments

(5 files, 2 obsolete files)

See TS 101.223, clause 7.5.6 Idle screen available event.
Assignee: nobody → chulee
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #0)
> See TS 101.223, clause 7.5.6 Idle screen available event.
 Sorry should be TS 102.223
Comment on attachment 705716 [details] [diff] [review]
0001. Add event object.

Review of attachment 705716 [details] [diff] [review]:
-----------------------------------------------------------------

Please also update comments in sendStkEventDownload nsIDOMIccManager.idl.

sr? for Jonas for IDL change.

::: dom/icc/interfaces/SimToolKit.idl
@@ +583,5 @@
>     */
>    DOMString language;
>  };
> +
> +dictionary MozStkGeneralEvent{

nit, please move { to next line.
Attachment #705716 - Flags: superreview?(jonas)
Attachment #705716 - Flags: review?(allstars.chh)
Attachment #705716 - Flags: review+
Attachment #705719 - Flags: review?(allstars.chh) → review+
Attachment #705720 - Flags: review?(allstars.chh) → review+
Comment on attachment 705721 [details] [diff] [review]
0004. Test case for Event Download Command : Idle Screen Available.

Review of attachment 705721 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +1517,5 @@
> +/**
> + * Verify Event Download Command : Idle Screen Available
> + */
> +add_test(function test_stk_event_download_idle_screen_available() {
> +  let worker = newUint8WithOutgoingIndexWorker();

I just realized this naming needs to be revised, at first I see 'WithOut'

@@ +1537,5 @@
> +
> +    // BER length, TLV_DEVICE_ID_SIZE(4) + TLV_EVENT_LIST_SIZE(3) = 7
> +    do_check_eq(pduHelper.readHexOctet(), 7);
> +
> +    // Device Identifies, Type-Length-Value(Source ID-Destination ID)

typo, Identities
Attachment #705721 - Flags: review?(allstars.chh) → review+
Rename worker as comment 7.

Also fix naming of a test function.
Attachment #705753 - Flags: review?(allstars.chh)
Attachment #705753 - Flags: review?(allstars.chh) → review+
Comment on attachment 705716 [details] [diff] [review]
0001. Add event object.

Review of attachment 705716 [details] [diff] [review]:
-----------------------------------------------------------------

An alternative is to use inheritance.
But I am okay either way.
Attachment #705716 - Flags: superreview?(jonas) → superreview+
Comment on attachment 705716 [details] [diff] [review]
0001. Add event object.

Review of attachment 705716 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, Chuck

Can you add sr=sicking for your IDL changed?

thanks
You need to log in before you can comment on or make changes to this bug.