831628 - B2G STK: Support "Idle Screen Available Event" Envelope command

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See TS 101.223, clause 7.5.6 Idle screen available event.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #0)
> See TS 101.223, clause 7.5.6 Idle screen available event.
 Sorry should be TS 102.223

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Add event object.

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Handle event.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0003. Mark event as supported.

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0004. Test case for Event Download Command : Idle Screen Available.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 705716 [details] [diff] [review]
0001. Add event object.

Review of attachment 705716 [details] [diff] [review]:
-----------------------------------------------------------------

Please also update comments in sendStkEventDownload nsIDOMIccManager.idl.

sr? for Jonas for IDL change.

::: dom/icc/interfaces/SimToolKit.idl
@@ +583,5 @@
>     */
>    DOMString language;
>  };
> +
> +dictionary MozStkGeneralEvent{

nit, please move { to next line.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 705721 [details] [diff] [review]
0004. Test case for Event Download Command : Idle Screen Available.

Review of attachment 705721 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/tests/test_ril_worker_icc.js
@@ +1517,5 @@
> +/**
> + * Verify Event Download Command : Idle Screen Available
> + */
> +add_test(function test_stk_event_download_idle_screen_available() {
> +  let worker = newUint8WithOutgoingIndexWorker();

I just realized this naming needs to be revised, at first I see 'WithOut'

@@ +1537,5 @@
> +
> +    // BER length, TLV_DEVICE_ID_SIZE(4) + TLV_EVENT_LIST_SIZE(3) = 7
> +    do_check_eq(pduHelper.readHexOctet(), 7);
> +
> +    // Device Identifies, Type-Length-Value(Source ID-Destination ID)

typo, Identities

Comment 8

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0004. Rename worker in test case

Rename worker as comment 7.

Also fix naming of a test function.

Comment 9

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0005. Test case for Event Download Command : Idle Screen Available, v1.1

Update test case using new worker name

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 705716 [details] [diff] [review]
0001. Add event object.

Review of attachment 705716 [details] [diff] [review]:
-----------------------------------------------------------------

An alternative is to use inheritance.
But I am okay either way.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 705716 [details] [diff] [review]
0001. Add event object.

Review of attachment 705716 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, Chuck

Can you add sr=sicking for your IDL changed?

thanks

Comment 12

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Add event object, v1.1

Address comment 6 and add sr.

Comment 13

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try server : https://tbpl.mozilla.org/?tree=Try&rev=2c1a6c0dfb4b

Comment 14

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1183f031c783
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b169983cdb
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f8b0e4a7e22
https://hg.mozilla.org/integration/mozilla-inbound/rev/f93346711a14
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c0e27333599

Comment 15

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/1183f031c783
https://hg.mozilla.org/mozilla-central/rev/f3b169983cdb
https://hg.mozilla.org/mozilla-central/rev/5f8b0e4a7e22
https://hg.mozilla.org/mozilla-central/rev/f93346711a14
https://hg.mozilla.org/mozilla-central/rev/5c0e27333599