Closed Bug 831687 Opened 7 years ago Closed 7 years ago

hook up hinted-glyph-advances callback in the graphite shaper

Categories

(Core :: Graphics: Text, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

(From bug 831277 comment 4.)

gfxGraphiteShaper includes code to use hinted glyph widths via a callback, but it fails to actually set the mUseFontGlyphWidths flag when appropriate and hence this option never actually gets used. This is why graphite rendering on windows tends to vary from opentype rendering even where no shaping/layout difference would be expected, more substantially than on other platforms (as windows may hint glyph advances pretty aggressively, depending on the cleartype mode).
With this fix, the graphite and harfbuzz renderings of Charis SIL (see http://people.mozilla.org/~jkew/charis-test.html) now match on Windows.
Attachment #703289 - Flags: review?(jdaggett)
Attachment #703289 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/0ac50fa858a7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.