8317 - SMOKETEST: Crash after Closing Editor after changing text

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Paul MacQuiddy]

Using 6/16 builds, I crash on all platforms if I...

1. Open the Editor via the Task Menu
2. Select Some Text
3. Modify the Text by makin it bold (or changing the color, or underline)
4. Deselect the text by DOUBLECLICKING in the Editor Window - you cannot
deselect the text with a single click, by the way (separate bug?)
5. Closing the Editor Window

Note: it seems that the double-click in the Editor Window is what is causing the
crash to occur. You can actually skip steps 2 and 3 to get the crash.

This is basically smoketest#27 at http://www.mozilla.org/quality/smoketests/


 Call Stack:    (Signature = 0x054e2883 572fa228)

   0x054e2883


   nsCaret::DrawCaret

[d:\builds\seamonkey\mozilla\layout\base\src\nsCaret.cpp, line 563]

   nsCaret::CaretBlinkCallback

[d:\builds\seamonkey\mozilla\layout\base\src\nsCaret.cpp, line 626]

   TimerImpl::Fire

[d:\builds\seamonkey\mozilla\gfx\src\windows\nsTimer.cpp, line 310]

   TimerImpl::ProcessTimeouts

[d:\builds\seamonkey\mozilla\gfx\src\windows\nsTimer.cpp, line 187]

   FireTimeout

[d:\builds\seamonkey\mozilla\gfx\src\windows\nsTimer.cpp, line 103]

   KERNEL32.DLL + 0x241d (0xbff7241d)


   FireTimeout

[d:\builds\seamonkey\mozilla\gfx\src\windows\nsTimer.cpp, line 83]

   USER32.DLL + 0x4cbd (0xbff64cbd)


   0x835b0003

Comment 1

[sujay]

yes I see this same behavior also.

Comment 2

[Simon Fraser [no longer active]]

This looks to me like someone is leaking refs to the document or pres shell on

double click. This is almost certainly in layout: cc:ing joki. I'll look for the

leak.

Comment 3

[Simon Fraser [no longer active]]

sujay: it would be helpful for you to pin down whether it's JUST the double
click that's needed here, or whether some other series of editing operations
causes the crash.

Comment 4

[sujay]

Its definitely triggered by the double-click along with the highlighting.
Here's How I can get it to crash every single time:

1) launch apprunner and editor
2) double-click to highlight text/word
3) make some change to it like Bold
4) exit apprunner by clicking on "X"
5) re-launch editor and wait a few seconds

crash

Comment 5

[Simon Fraser [no longer active]]

Is step 3 necessary?

Comment 6

[sujay]

actually just tried it again...Nope, step 3 is not necessary.

Comment 7

[Simon Fraser [no longer active]]

OK, I got it. mjudge was leaking the caret.

Comment 8

[Simon Fraser [no longer active]]

Have a reviewed fix in hand.

Comment 9

[Simon Fraser [no longer active]]

Fix checked in.

Comment 10

[sujay]

verified in 6/17 build.