Closed
Bug 831707
Opened 13 years ago
Closed 13 years ago
Use -static-libgcc and -static-libstdc++ on mingw if possible
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file, 1 obsolete file)
2.07 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This avoids unneeded dependency and will simplify mozconfig required for mingw builds:
https://developer.mozilla.org/en-US/docs/Cross_Compile_Mozilla_for_Mingw32
Attachment #703261 -
Flags: review?(mh+mozilla)
Comment 1•13 years ago
|
||
Comment on attachment 703261 [details] [diff] [review]
fix
Review of attachment 703261 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +2143,5 @@
> MOZ_C_SUPPORTS_WARNING(-Wno-, format, ac_c_has_wno_format)
> MOZ_CXX_SUPPORTS_WARNING(-Wno-, format, ac_cxx_has_wno_format)
> +
> + # Use static libgcc and libstdc++ if possible
> + AC_MSG_CHECKING([for -static-libgcc option])
Is it even possible that these flags are not supported? I'd just add them unconditionally to LDFLAGS for mingw.
Attachment #703261 -
Flags: review?(mh+mozilla) → review-
Assignee | ||
Comment 2•13 years ago
|
||
Yes, such toolchain builds exist. However, I asked mingw-w64 guys about them and it seems like can ignore those (these are some packages with patched gcc, not really supported by mingw(-w64)).
The attached patch adds those arguments unconditionally.
Attachment #703261 -
Attachment is obsolete: true
Attachment #704825 -
Flags: review?(mh+mozilla)
Updated•13 years ago
|
Attachment #704825 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Thanks for reviews.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9523a36fc918
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•